Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 010: Modular AnteHandler #4942

Merged
merged 16 commits into from
Aug 28, 2019
Merged

ADR 010: Modular AnteHandler #4942

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2958790
initial adr
AdityaSripal Aug 21, 2019
822357c
add ref links
AdityaSripal Aug 21, 2019
a966964
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 22, 2019
05e65e7
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 22, 2019
142dfb7
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 22, 2019
3c0475a
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 22, 2019
46f42cc
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 22, 2019
02e80c2
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 22, 2019
318c34d
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 22, 2019
58c06ce
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 22, 2019
fbc6a41
address ethan comments. Change AnteHandler return value to ctx, error
AdityaSripal Aug 22, 2019
df805f0
add simple decorators proposal
AdityaSripal Aug 26, 2019
249e8ef
final updates
AdityaSripal Aug 27, 2019
c9e3ff7
Update docs/architecture/adr-009-modular-antehandler.md
alexanderbez Aug 28, 2019
d8825e7
Merge branch 'master' into aditya/modular-ante-adr
alexanderbez Aug 28, 2019
e8e7975
Update TOC
alexanderbez Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs/architecture/adr-009-modular-antehandler.md
  • Loading branch information
@alexanderbez
alexanderbez committed Aug 22, 2019
commit 02e80c2f1aa1aa291565dda558e4da6571034c49
2 changes: 1 addition & 1 deletion docs/architecture/adr-009-modular-antehandler.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Cons:
1. Improves granularity but still cannot get more granular than a per-module basis. If auth's `AnteHandle` function is in charge of validating memo and signatures, users cannot swap the signature-checking functionality while keeping the rest of auth's AnteHandle functionality.
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
2. Module AnteHandler are run one after the other. There is no way for one AnteHandler to wrap or "decorate" another.

### Weave Decorators
### Decorator Pattern

The [weave project](https://github.com/iov-one/weave) achieves AnteHandler modularity through the use of a decorator pattern. The interface is designed as follows:

Expand Down