Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CPU Profiling via CLI flag #4973

Merged
merged 5 commits into from
Aug 30, 2019
Merged

Enable CPU Profiling via CLI flag #4973

merged 5 commits into from
Aug 30, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 29, 2019 •
edited
Loading

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added R4R T: Performance Performance improvements labels Aug 29, 2019
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #4973 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4973   +/-   ##
=======================================
  Coverage   55.53%   55.53%           
=======================================
  Files         284      284           
  Lines       17462    17462           
=======================================
  Hits         9698     9698           
  Misses       7069     7069           
  Partials      695      695

AdityaSripal
AdityaSripal approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

server/start.go Outdated Show resolved Hide resolved
alexanderbez and others added 2 commits August 29, 2019 16:04
@alexanderbez @AdityaSripal
Update server/start.go
413cb46 
Co-Authored-By: Aditya <adityasripal@gmail.com>
@alexanderbez
Update log message
3a1db91
@alexanderbez
Copy link
Contributor Author

DNM yet, I need to fix TrapSignal.

@alexanderbez alexanderbez merged commit 1cd124a into master Aug 30, 2019
@alexanderbez alexanderbez deleted the bez/enable-cpu-profiling branch August 30, 2019 15:46
alexanderbez added a commit that referenced this pull request Sep 17, 2019
@alexanderbez
Merge PR #4973: Enable CPU Profiling via CLI flag
733f734
@alexanderbez alexanderbez mentioned this pull request Sep 17, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
T: Performance Performance improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderbez @AdityaSripal