Standardise and clean up Makefile #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 10, 2019 16:01
Use check- prefix for test- targets to adhere to Make's standard naming convention [1]. Snake-case names are abandoned in favor of kebab-case naming convention. [1] https://www.gnu.org/prep/standards/html_node/Standard-Targets.html
alessio
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5025 +/- ##
=========================================
+ Coverage 55.5% 55.5% +<.01%
=========================================
Files 287 287
Lines 17538 17540 +2
=========================================
+ Hits 9734 9736 +2
+ Misses 7104 7103 -1
- Partials 700 701 +1 |
alessio
requested review from
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
fedekunze
suggested changes
Sep 10, 2019
.circleci/config.yml
Outdated
| @@ -78,35 +78,35 @@ jobs: | |||
| executor: golang | |||
| steps: | |||
| - make: | |||
| target: test_sim_nondeterminism | |||
| target: test-sim-nondeterminism | |||
| description: "Test individual module simulations" | |||
|
|
|||
| test_sim_import_export: | |||
There was a problem hiding this comment.
we should update these too
There was a problem hiding this comment.
Fede, if I renamed workflow steps CI would fail. I'd propose to normalise the Makefile targets only in the context of this PR. Does that work for you?
fedekunze
approved these changes
Sep 10, 2019
|
@alessio do you mind fixing CI? |
|
CI is fixed. Merging is blocked because CircleCI build needs manual intervention as this PR amends the build configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snake-case names are abandoned in favor of
kebab-case naming convention.
Remove goimports from tools.
Ref: cosmos/gaia#120
docs/)Unreleasedsection inCHANGELOG.mdFiles changedin the github PR explorerFor Admin Use: