x/nft Ownership #5071
Merged
x/nft Ownership #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5071 +/- ##
=======================================
Coverage 54.79% 54.79%
=======================================
Files 294 294
Lines 18222 18222
=======================================
Hits 9984 9984
Misses 7492 7492
Partials 746 746 |
alexanderbez
commented
Sep 19, 2019
| @@ -0,0 +1,4 @@ | |||
| # Contract | |||
|
|
|||
There was a problem hiding this comment.
@fedekunze @okwme @rigelrozanski Would like input here on what we would typically expect and/or want in a soft contract for module ownership and maintenance.
There was a problem hiding this comment.
- Review issues and pull requests related to the module
- Resolve issues and pull requests within 90 days
- Ensure module is ready for SDK releases
alexanderbez
requested review from
jackzampolin,
fedekunze,
rigelrozanski and
okwme
alexanderbez
commented
Sep 19, 2019
|
|
||
| # The following contributors own all files in the x/nft directory at the root | ||
| # of the repository and any of its subdirectories. | ||
| x/nft @okwme @fedekunze |
There was a problem hiding this comment.
@fedekunze @okwme if there are other contributors you'd like to add, please add them here.
fedekunze
approved these changes
Sep 20, 2019
tnachen
approved these changes
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5036
ref: #5058
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: