Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/ibc ICS24 #5588

Merged
merged 15 commits into from
Feb 19, 2020
Merged

x/ibc ICS24 #5588

merged 15 commits into from
Feb 19, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jan 29, 2020

Description

Adds subpackage 24-host/ to the ibc module, that incorporates the changes from the ICS 024 - Host State Machine Requirements spec.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that I don't understand the "paths as sets" bit - paths aren't sets.

x/ibc/24-host/utils.go Show resolved Hide resolved
@cwgoes
Copy link
Contributor

cwgoes commented Feb 4, 2020

Do we use these identifier validation functions in ValidateBasic on messages elsewhere?

(question from @jackzampolin)

@cwgoes
Copy link
Contributor

cwgoes commented Feb 17, 2020

Sounds like we don't have a Set type for now, we'll deal with this later.

x/ibc/24-host/validate.go Outdated Show resolved Hide resolved
types/router.go Outdated Show resolved Hide resolved
x/ibc/24-host/validate.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ☕️

@alexanderbez alexanderbez merged commit 4aa078b into master Feb 19, 2020
@alexanderbez alexanderbez deleted the ib-ics24-host-requirements branch February 19, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants