Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve crypto/keys docs #5830

Closed
wants to merge 2 commits into from
Closed

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 19, 2020

In addition to #5822


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@@ -0,0 +1,47 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package comment should not have leading space (from golint)

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #5830 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5830   +/-   ##
=======================================
  Coverage   32.30%   32.30%           
=======================================
  Files         353      353           
  Lines       39461    39461           
=======================================
  Hits        12749    12749           
  Misses      25439    25439           
  Partials     1273     1273           

@alessio
Copy link
Contributor Author

alessio commented Mar 19, 2020

superseded by #5833

@alessio alessio closed this Mar 19, 2020
@alessio alessio deleted the alessio/keyring-pass-support branch March 19, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants