-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bank proto buf migration #6166
Bank proto buf migration #6166
Conversation
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been For contributor use:
For admin use:
Thank you for your contribution to the Cosmos-SDK! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #6166 +/- ##
==========================================
- Coverage 54.84% 54.82% -0.02%
==========================================
Files 444 443 -1
Lines 26766 26767 +1
==========================================
- Hits 14679 14675 -4
- Misses 11043 11050 +7
+ Partials 1044 1042 -2 |
} | ||
|
||
extend google.protobuf.FieldOptions { | ||
string accepts_interface = 93001; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronc shall we use a different range here, 94xxx?
string accepts_interface = 93001; | |
string accepts_interface = 94001; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but this should be coordinated upstream in the cosmos-proto repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK pending lint fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Please resolve conflicts/rebase and we can merge 👍 |
Description
closes: #XXXX