Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank proto buf migration #6166

Merged
merged 10 commits into from
May 12, 2020
Merged

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented May 7, 2020

Description

closes: #XXXX

@auto-comment
Copy link

auto-comment bot commented May 7, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #6166 into master will decrease coverage by 0.01%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #6166      +/-   ##
==========================================
- Coverage   54.84%   54.82%   -0.02%     
==========================================
  Files         444      443       -1     
  Lines       26766    26767       +1     
==========================================
- Hits        14679    14675       -4     
- Misses      11043    11050       +7     
+ Partials     1044     1042       -2     

}

extend google.protobuf.FieldOptions {
string accepts_interface = 93001;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronc shall we use a different range here, 94xxx?

Suggested change
string accepts_interface = 93001;
string accepts_interface = 94001;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but this should be coordinated upstream in the cosmos-proto repo

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending lint fix

x/bank/module.go Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez
Copy link
Contributor

Please resolve conflicts/rebase and we can merge 👍

@aaronc aaronc added the T: Proto Breaking Protobuf breaking changes: generally don't do this! label May 12, 2020
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 12, 2020
@mergify mergify bot merged commit da92383 into cosmos:master May 12, 2020
@sahith-narahari sahith-narahari deleted the atheesh/x-bank-proto-any branch May 12, 2020 17:52
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding C:x/bank T: Proto Breaking Protobuf breaking changes: generally don't do this!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants