Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automate release post tag push #6230

Merged
merged 14 commits into from
May 25, 2020
Merged

ci: automate release post tag push #6230

merged 14 commits into from
May 25, 2020

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented May 15, 2020

Description

add automation to make release when tag is pushed

closes: #XXXX

@tac0turtle tac0turtle self-assigned this May 15, 2020
@auto-comment
Copy link

auto-comment bot commented May 15, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@tac0turtle tac0turtle marked this pull request as ready for review May 19, 2020 15:19
@tac0turtle tac0turtle added T: CI T:Docs Changes and features related to documentation. labels May 19, 2020
.github/workflows/tag.yml Outdated Show resolved Hide resolved
.github/workflows/tag.yml Outdated Show resolved Hide resolved
.github/workflows/tag.yml Outdated Show resolved Hide resolved
tags:
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10

jobs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how does this work? What does this buy us?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you push a tag a GitHub bot will and create the release on the releases page. This will help keep consistency on the release page when there are more people doing releases.

.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/release-sims.yml Outdated Show resolved Hide resolved
.github/workflows/release-sims.yml Outdated Show resolved Hide resolved
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags regex seems incorrect

.github/workflows/tag.yml Outdated Show resolved Hide resolved
.github/workflows/tag.yml Outdated Show resolved Hide resolved
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alessio alessio merged commit 21a9cb9 into master May 25, 2020
@alessio alessio deleted the marko/releaser2 branch May 25, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: CI T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants