Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: remove Hans #6243

Merged
merged 1 commit into from
May 18, 2020
Merged

CODEOWNERS: remove Hans #6243

merged 1 commit into from
May 18, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 18, 2020


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@alessio alessio added the R4R label May 18, 2020
@alessio alessio changed the title remove Hans CODEOWNERS: remove Hans May 18, 2020
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #6243 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6243   +/-   ##
=======================================
  Coverage   54.75%   54.75%           
=======================================
  Files         447      447           
  Lines       26892    26892           
=======================================
  Hits        14726    14726           
  Misses      11123    11123           
  Partials     1043     1043           

@@ -1,4 +1,4 @@
# CODEOWNERS: https://help.github.com/articles/about-codeowners/

# Primary repo maintainers
* @alexanderbez @alessio @fedekunze @nylira @hschoenburg @aaronc @clevinson @jgimeno
* @alexanderbez @alessio @fedekunze @nylira @aaronc @clevinson @jgimeno
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to sound rude, but is there a reason for @nylira to be here? He doesn't contribute code, create issues nor participates in technical SDK discussions...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have to be on this list. I trust the other CODEOWNERS to make good engineering decisions for the Cosmos ecosystem.

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 18, 2020
@mergify mergify bot merged commit 0db51de into master May 18, 2020
@mergify mergify bot deleted the codeowners branch May 18, 2020 15:12
@alessio alessio mentioned this pull request May 18, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants