Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simapp Localnet #6421

Merged
merged 8 commits into from
Jun 12, 2020
Merged

Simapp Localnet #6421

merged 8 commits into from
Jun 12, 2020

Conversation

alexanderbez
Copy link
Contributor

Description

Drop-n-lift localnet functionality from Gaia. So we no longer have to rely on Gaia.

closes: #6418


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #6421 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #6421   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files         465      465           
  Lines       27674    27674           
=======================================
  Hits        15404    15404           
  Misses      11169    11169           
  Partials     1101     1101           

@alexanderbez alexanderbez marked this pull request as ready for review June 12, 2020 15:52
@alexanderbez alexanderbez added R4R and removed WIP labels Jun 12, 2020
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would we want to publish a docker image somewhere?

simapp/cmd/simd/testnet.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor Author

LGTM, would we want to publish a docker image somewhere?

Why? This is just a simapp used for local testing and integration purposes.

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 12, 2020
@mergify mergify bot merged commit 7871910 into master Jun 12, 2020
@mergify mergify bot deleted the bez/6418-localnet branch June 12, 2020 16:23
@aaronc
Copy link
Member

aaronc commented Jun 18, 2020

@alexanderbez just curious, is there a reason we couldn't also do this by spinning off sub-processes instead of docker compose? It seems that would be more portable for other apps. We could have a testnet init command that populates all the directories as in this PR and then a testnet start command that spins off n sub-processes with those configs. What do you think?

@alexanderbez
Copy link
Contributor Author

There are many many ways you can do this. This has existed before I worked on the SDK and I just simply replicated the process because it works and is simple. I will note that I generally am in favor of Docker (compose) and would prefer to stay that route. App devs can implement this however they wish. The SDK doesn't aim to provide devops tooling.

@alessio
Copy link
Contributor

alessio commented Jun 18, 2020

I will note that I generally am in favor of Docker (compose) and would prefer to stay that route

I agree with this.

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Setup localnet

* Fix compose

* Fix file perms

* Fix build

* Codec + lint updates

* lint++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding localnet capabilities to SimApp
5 participants