Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TxBuilder to use SignatureV2 #6443

Merged
merged 16 commits into from
Jun 16, 2020
Merged

Update TxBuilder to use SignatureV2 #6443

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a8496c8
Update TxBuilder to use SignatureV2
aaronc Jun 15, 2020
4122014
Fix unit tests
aaronc Jun 15, 2020
b488d5c
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…
aaronc Jun 15, 2020
38d9402
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…
aaronc Jun 15, 2020
c32cb7b
Lint
aaronc Jun 15, 2020
7587a6e
lint
aaronc Jun 15, 2020
54f1e55
Cleanup
aaronc Jun 15, 2020
07c520e
Address review feedback
aaronc Jun 16, 2020
f7fe1b3
Add Sign tests
anilcse Jun 16, 2020
14182ee
Add more cases for sign tests
anilcse Jun 16, 2020
3326a4f
Fix lint
anilcse Jun 16, 2020
f2c553d
Fix gofmt
anilcse Jun 16, 2020
cdeef28
Merge branch 'master' into aaronc/6213-sig-v2-builder
aaronc Jun 16, 2020
06d8501
Deprecate StdTx
aaronc Jun 16, 2020
95d0221
Undeprecate StdTx, but leave a comment to use the protobuf Tx
aaronc Jun 16, 2020
a1bc491
Address review comment
aaronc Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Undeprecate StdTx, but leave a comment to use the protobuf Tx
  • Loading branch information
@aaronc
aaronc committed Jun 16, 2020
commit 95d0221c6d7ded6aee9d2c13def02795144f75ad
3 changes: 2 additions & 1 deletion x/auth/types/stdtx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ func CountSubKeys(pub crypto.PubKey) int {

var _ sdk.Tx = (*StdTx)(nil)

// Deprecated: StdTx is a standard way to wrap a Msg with Fee and Signatures.
// StdTx is the legacy transaction format for wrapping a Msg with Fee and Signatures.
// It only works with Amino, please prefer the new protobuf Tx in types/tx.
// NOTE: the first signature is the fee payer (Signatures must not be nil).
type StdTx struct {
Msgs []sdk.Msg `json:"msg" yaml:"msg"`
Expand Down