Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve IBC guide #6472

Merged
merged 19 commits into from
Jul 7, 2020
Merged

docs: improve IBC guide #6472

merged 19 commits into from
Jul 7, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jun 19, 2020

Description

closes: #6484

  • minor docs fixes

IBC:

  • Create IBC section
  • IBC overview
  • IBC Integration to app.go with ICS 20 transfers only
  • Create your own IBC custom app module (i.e current content)

(Follow up PR) - Ocaps:

  • Complete ocap.md with capability module contents
  • capability module spec update

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@fedekunze fedekunze added T:Docs Changes and features related to documentation. WIP labels Jun 19, 2020
@fedekunze fedekunze changed the title docs: improve IBC guide docs: improve IBC guide and ocap Jun 19, 2020
@fedekunze fedekunze changed the title docs: improve IBC guide and ocap docs: improve IBC and ocaps guides Jun 19, 2020
@fedekunze fedekunze mentioned this pull request Jun 22, 2020
8 tasks
@fedekunze fedekunze mentioned this pull request Jun 23, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 4, 2020
@alexanderbez alexanderbez removed the WIP label Jul 7, 2020
@fedekunze fedekunze removed the stale label Jul 7, 2020
@fedekunze fedekunze marked this pull request as ready for review July 7, 2020 08:49
@fedekunze fedekunze added the x/ibc label Jul 7, 2020
@fedekunze fedekunze changed the title docs: improve IBC and ocaps guides docs: improve IBC guide Jul 7, 2020
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 7, 2020
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending updates to acknowledgement literature

docs/core/events.md Outdated Show resolved Hide resolved
docs/core/telemetry.md Outdated Show resolved Hide resolved
docs/ibc/custom.md Outdated Show resolved Hide resolved
docs/ibc/integration.md Outdated Show resolved Hide resolved
docs/ibc/integration.md Outdated Show resolved Hide resolved
docs/ibc/integration.md Outdated Show resolved Hide resolved
docs/ibc/overview.md Outdated Show resolved Hide resolved
docs/ibc/custom.md Outdated Show resolved Hide resolved
docs/ibc/custom.md Outdated Show resolved Hide resolved
docs/ibc/custom.md Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit be194ca into master Jul 7, 2020
@fedekunze fedekunze deleted the fedekunze/docs branch July 7, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBC developer guide
3 participants