Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Network Testing Framework #6489

Merged
merged 39 commits into from
Jun 26, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
c9d5b34
Init commit
alexanderbez Jun 23, 2020
1e651e8
Remove script
alexanderbez Jun 23, 2020
9d8494f
Merge branch 'master' into bez/in-process-test-framework
alexanderbez Jun 23, 2020
cd2ec2d
Fix IBC codec bug
alexanderbez Jun 23, 2020
ecfa3c8
go mod tidy + codec fixes attempt
alexanderbez Jun 23, 2020
c7e9b60
Change base dir to use chain-id
alexanderbez Jun 23, 2020
f5deb8d
Add trap signal call
alexanderbez Jun 23, 2020
7f51e12
Add godoc
alexanderbez Jun 23, 2020
b7c2cca
Merge branch 'master' into bez/in-process-test-framework
alexanderbez Jun 23, 2020
ec88212
Updates
alexanderbez Jun 23, 2020
4f43424
Tweaks
alexanderbez Jun 23, 2020
e8f5176
Fix fn name
alexanderbez Jun 23, 2020
433b67e
Cleanup
alexanderbez Jun 23, 2020
f7758f7
Only allow 1st val to serve rpc/api
alexanderbez Jun 24, 2020
4bc56bd
use pkg lock
alexanderbez Jun 24, 2020
d430884
Merge branch 'master' into bez/in-process-test-framework
alexanderbez Jun 24, 2020
c389c81
lint++
alexanderbez Jun 24, 2020
a6f8fe3
lint++
alexanderbez Jun 24, 2020
9442a8b
Remove use of errgroup
alexanderbez Jun 24, 2020
0aff4e4
ci: remove -race flag from tests
alexanderbez Jun 24, 2020
69603bc
Merge branch 'master' into bez/in-process-test-framework
alexanderbez Jun 24, 2020
6d1719f
Add doc
alexanderbez Jun 25, 2020
c53831d
Merge branch 'master' into bez/in-process-test-framework
alexanderbez Jun 25, 2020
ff14f0d
Merge branch 'master' into bez/in-process-test-framework
fedekunze Jun 25, 2020
93454e5
cl++
alexanderbez Jun 25, 2020
52aa585
Add section to godoc
alexanderbez Jun 25, 2020
f889a0b
testutil: address comments
alexanderbez Jun 25, 2020
cdc9db6
Update testutil/doc.go
alexanderbez Jun 25, 2020
8aa5c71
Update testutil/doc.go
alexanderbez Jun 25, 2020
426505e
Update testutil/doc.go
alexanderbez Jun 25, 2020
c6a208a
testutil: make app confiruable
alexanderbez Jun 26, 2020
05fd4a7
testutil: update go doc
alexanderbez Jun 26, 2020
38aac75
Merge branch 'bez/in-process-test-framework' of github.com:cosmos/cos…
alexanderbez Jun 26, 2020
195447e
testutil: revise app con
alexanderbez Jun 26, 2020
939b6c3
testutil: update go doc
alexanderbez Jun 26, 2020
9c77941
Fixes
alexanderbez Jun 26, 2020
89a447d
Merge branch 'master' into bez/in-process-test-framework
alexanderbez Jun 26, 2020
df0b1b6
Merge branch 'master' into bez/in-process-test-framework
mergify[bot] Jun 26, 2020
ddb342b
Merge branch 'master' into bez/in-process-test-framework
mergify[bot] Jun 26, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Init commit
  • Loading branch information
alexanderbez committed Jun 23, 2020
commit c9d5b34276cd00514603fc8f9371edc7133030c6
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ require (
github.com/tendermint/tendermint v0.33.5
github.com/tendermint/tm-db v0.5.1
golang.org/x/crypto v0.0.0-20200604202706-70a84ac30bf9 // indirect
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
google.golang.org/grpc v1.29.1
google.golang.org/protobuf v1.24.0 // indirect
gopkg.in/yaml.v2 v2.3.0
Expand Down
1 change: 1 addition & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,7 @@ golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJ
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20190227155943-e225da77a7e6/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e h1:vcxGaoTs7kV8m5Np9uUNQin4BrLOthgV7252N8V+FwY=
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sys v0.0.0-20180823144017-11551d06cbcc/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
Expand Down
16 changes: 14 additions & 2 deletions server/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"fmt"
"os"
"runtime/pprof"
"time"

"github.com/spf13/cobra"
"github.com/spf13/viper"
Expand Down Expand Up @@ -192,8 +193,9 @@ func startInProcess(ctx *Context, cdc codec.JSONMarshaler, appCreator AppCreator
return err
}

config := config.GetConfig()
var apiSrv *api.Server

config := config.GetConfig()
if config.API.Enable {
genDoc, err := genDocProvider()
if err != nil {
Expand All @@ -213,8 +215,18 @@ func startInProcess(ctx *Context, cdc codec.JSONMarshaler, appCreator AppCreator
apiSrv = api.New(ctx)
app.RegisterAPIRoutes(apiSrv)

if err := apiSrv.Start(config); err != nil {
errCh := make(chan error)

go func() {
if err := apiSrv.Start(config); err != nil {
errCh <- err
}
}()

select {
case err := <-errCh:
return err
case <-time.After(5 * time.Second): // assume server started successfully
Comment on lines -223 to +236
Copy link
Contributor Author

@alexanderbez alexanderbez Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not realize Tendermint HTTP client actually blocks -- this fixes that so we can properly cleanup below.

}
}

Expand Down
281 changes: 281 additions & 0 deletions testutil/network.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,281 @@
package testutil

import (
"bufio"
"encoding/json"
"fmt"
"net/url"
"os"
"path/filepath"
"testing"
"time"

"github.com/stretchr/testify/require"
tmcfg "github.com/tendermint/tendermint/config"
"github.com/tendermint/tendermint/crypto"
tmflags "github.com/tendermint/tendermint/libs/cli/flags"
"github.com/tendermint/tendermint/libs/log"
tmrand "github.com/tendermint/tendermint/libs/rand"
"github.com/tendermint/tendermint/node"
tmclient "github.com/tendermint/tendermint/rpc/client"
"golang.org/x/sync/errgroup"

"github.com/cosmos/cosmos-sdk/client"
clientkeys "github.com/cosmos/cosmos-sdk/client/keys"
"github.com/cosmos/cosmos-sdk/crypto/keyring"
"github.com/cosmos/cosmos-sdk/server"
"github.com/cosmos/cosmos-sdk/server/api"
srvconfig "github.com/cosmos/cosmos-sdk/server/config"
"github.com/cosmos/cosmos-sdk/simapp"
storetypes "github.com/cosmos/cosmos-sdk/store/types"
sdk "github.com/cosmos/cosmos-sdk/types"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
"github.com/cosmos/cosmos-sdk/x/genutil"
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
)

var (
_, cdc = simapp.MakeCodecs()
)

// Config defines the necessary configuration used to bootstrap and start an
// in-process local testing network.
type Config struct {
GenesisState map[string]json.RawMessage
TimeoutCommit time.Duration
ChainID string
NumValidators int
BondDenom string
MinGasPrices string
Passphrase string
AccountTokens sdk.Int
StakingTokens sdk.Int
BondedTokens sdk.Int
EnableLogging bool
}

// DefaultConfig returns a sane default configuration suitable for nearly all
// testing requirements.
func DefaultConfig() Config {
return Config{
GenesisState: simapp.ModuleBasics.DefaultGenesis(cdc),
TimeoutCommit: 2 * time.Second,
ChainID: "chain-" + tmrand.NewRand().Str(6),
NumValidators: 4,
BondDenom: sdk.DefaultBondDenom,
MinGasPrices: fmt.Sprintf("0.000006%s", sdk.DefaultBondDenom),
Passphrase: clientkeys.DefaultKeyPass,
AccountTokens: sdk.TokensFromConsensusPower(1000),
StakingTokens: sdk.TokensFromConsensusPower(500),
BondedTokens: sdk.TokensFromConsensusPower(100),
}
}

type (
// Network defines a local in-process testing network using SimApp. It can be
// configured to start any number of validators, each with its own RPC and API
AdityaSripal marked this conversation as resolved.
Show resolved Hide resolved
// clients. Typically, this test network would be used in client and integration
// testing where user input is expected.
Network struct {
T *testing.T
BaseDir string
Validators []*Validator
}

// Validator defines an in-process Tendermint validator node. Through this object,
// a client can make RPC and API calls and interact with any client command
// or handler.
Validator struct {
AppConfig *srvconfig.Config
ClientCtx client.Context
Ctx *server.Context
Dir string
NodeID string
PubKey crypto.PubKey
Moniker string
RPCAddress string
P2PAddress string
Address sdk.AccAddress
ValAddress sdk.ValAddress
RPCClient tmclient.Client

tmNode *node.Node
api *api.Server
}
)

func NewTestNetwork(t *testing.T, cfg Config) *Network {
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
network := &Network{
T: t,
BaseDir: os.TempDir(),
Validators: make([]*Validator, cfg.NumValidators),
}

t.Log("preparing test network...")

monikers := make([]string, cfg.NumValidators)
nodeIDs := make([]string, cfg.NumValidators)
valPubKeys := make([]crypto.PubKey, cfg.NumValidators)

var (
genAccounts []authtypes.GenesisAccount
genBalances []banktypes.Balance
genFiles []string
)

buf := bufio.NewReader(os.Stdin)

// generate private keys, node IDs, and initial transactions
for i := 0; i < cfg.NumValidators; i++ {
appCfg := srvconfig.DefaultConfig()
appCfg.Pruning = storetypes.PruningOptionNothing
appCfg.MinGasPrices = cfg.MinGasPrices
appCfg.API.Enable = true
appCfg.API.Swagger = false
appCfg.Telemetry.Enabled = false

apiAddr, _, err := server.FreeTCPAddr()
require.NoError(t, err)
appCfg.API.Address = apiAddr

ctx := server.NewDefaultContext()
tmCfg := ctx.Config
tmCfg.Consensus.TimeoutCommit = cfg.TimeoutCommit

logger := log.NewNopLogger()
if cfg.EnableLogging {
logger = log.NewTMLogger(log.NewSyncWriter(os.Stdout))
logger, _ = tmflags.ParseLogLevel("info", logger, tmcfg.DefaultLogLevel())
}

ctx.Logger = logger

nodeDirName := fmt.Sprintf("node%d", i)
nodeDir := filepath.Join(network.BaseDir, nodeDirName, "simd")
clientDir := filepath.Join(network.BaseDir, nodeDirName, "simcli")
gentxsDir := filepath.Join(network.BaseDir, "gentxs")

require.NoError(t, os.MkdirAll(filepath.Join(nodeDir, "config"), 0755))
require.NoError(t, os.MkdirAll(clientDir, 0755))

tmCfg.SetRoot(nodeDir)
tmCfg.Moniker = nodeDirName
monikers[i] = nodeDirName

proxyAddr, _, err := server.FreeTCPAddr()
require.NoError(t, err)
tmCfg.ProxyApp = proxyAddr

rpcAddr, _, err := server.FreeTCPAddr()
require.NoError(t, err)
tmCfg.RPC.ListenAddress = rpcAddr

p2pAddr, _, err := server.FreeTCPAddr()
require.NoError(t, err)
tmCfg.P2P.ListenAddress = p2pAddr
tmCfg.P2P.AddrBookStrict = false
tmCfg.P2P.AllowDuplicateIP = true

nodeID, pubKey, err := genutil.InitializeNodeValidatorFiles(tmCfg)
require.NoError(t, err)
nodeIDs[i] = nodeID
valPubKeys[i] = pubKey

kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, clientDir, buf)
require.NoError(t, err)

addr, secret, err := server.GenerateSaveCoinKey(kb, nodeDirName, cfg.Passphrase, true)
require.NoError(t, err)

info := map[string]string{"secret": secret}
infoBz, err := json.Marshal(info)
require.NoError(t, err)

// save private key seed words
require.NoError(t, writeFile(fmt.Sprintf("%v.json", "key_seed"), clientDir, infoBz))

balances := sdk.Coins{
sdk.NewCoin(fmt.Sprintf("%stoken", nodeDirName), cfg.AccountTokens),
sdk.NewCoin(cfg.BondDenom, cfg.StakingTokens),
}

genFiles = append(genFiles, tmCfg.GenesisFile())
genBalances = append(genBalances, banktypes.Balance{Address: addr, Coins: balances.Sort()})
genAccounts = append(genAccounts, authtypes.NewBaseAccount(addr, nil, 0, 0))

createValMsg := stakingtypes.NewMsgCreateValidator(
sdk.ValAddress(addr),
valPubKeys[i],
sdk.NewCoin(sdk.DefaultBondDenom, cfg.BondedTokens),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps an extension worth implementing in a future PR. In addition to different validator configs as mentioned above, we should allow initializing networks with unequal token distributions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

stakingtypes.NewDescription(nodeDirName, "", "", "", ""),
stakingtypes.NewCommissionRates(sdk.OneDec(), sdk.OneDec(), sdk.OneDec()),
sdk.OneInt(),
)

p2pURL, err := url.Parse(p2pAddr)
require.NoError(t, err)

memo := fmt.Sprintf("%s@%s:%s", nodeIDs[i], p2pURL.Hostname(), p2pURL.Port())
tx := authtypes.NewStdTx([]sdk.Msg{createValMsg}, authtypes.StdFee{}, []authtypes.StdSignature{}, memo) //nolint:staticcheck // SA1019: authtypes.StdFee is deprecated
txBldr := authtypes.TxBuilder{}.WithChainID(cfg.ChainID).WithMemo(memo).WithKeybase(kb)

signedTx, err := txBldr.SignStdTx(nodeDirName, tx, false)
require.NoError(t, err)

txBz, err := cdc.MarshalJSON(signedTx)
require.NoError(t, err)
require.NoError(t, writeFile(fmt.Sprintf("%v.json", nodeDirName), gentxsDir, txBz))

srvconfig.WriteConfigFile(filepath.Join(nodeDir, "config/app.toml"), appCfg)

network.Validators[i] = &Validator{
AppConfig: appCfg,
Ctx: ctx,
Dir: filepath.Join(network.BaseDir, nodeDirName),
NodeID: nodeID,
PubKey: pubKey,
Moniker: nodeDirName,
RPCAddress: rpcAddr,
P2PAddress: p2pAddr,
Address: addr,
ValAddress: sdk.ValAddress(addr),
}
}

require.NoError(t, initGenFiles(cfg, genAccounts, genBalances, genFiles))
require.NoError(t, collectGenFiles(cfg, network.Validators, network.BaseDir))

t.Log("starting test network...")
var eg errgroup.Group
for _, v := range network.Validators {
val := v
eg.Go(func() error {
return startInProcess(cfg, val)
})
}

require.NoError(t, eg.Wait())
t.Log("started test network")

// TODO: Do we need to trap signal

return network
}

func (n *Network) Cleanup() {
n.T.Log("cleaning up test network...")

for _, v := range n.Validators {
if v.tmNode != nil && v.tmNode.IsRunning() {
_ = v.tmNode.Stop()
}

if v.api != nil {
_ = v.api.Close()
}
}

_ = os.RemoveAll(n.BaseDir)
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
n.T.Log("finished cleaning up test network")
}
34 changes: 34 additions & 0 deletions testutil/network_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package testutil

import (
"testing"
"time"

"github.com/stretchr/testify/require"
)

func TestNetwork_Liveness(t *testing.T) {
n := NewTestNetwork(t, DefaultConfig())
defer n.Cleanup()

require.NotNil(t, n)
require.NotEmpty(t, n.Validators)
client := n.Validators[0].RPCClient
require.NotNil(t, client)

ticker := time.NewTicker(5 * time.Second)
timeout := time.After(time.Minute)

for {
select {
case <-ticker.C:
s, _ := client.Status()
if s != nil && s.SyncInfo.LatestBlockHeight >= 10 {
t.Logf("successfully process %d blocks", s.SyncInfo.LatestBlockHeight)
return
}
case <-timeout:
t.Fatal("timeout exceeded waiting for enough committed blocks")
}
}
}
Loading