Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtered pagination #6514

Merged
merged 21 commits into from
Jul 1, 2020
Merged

Add filtered pagination #6514

merged 21 commits into from
Jul 1, 2020

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Jun 25, 2020

Description

Ref: #6191 (comment)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

types/query/filtered-pagination.go Outdated Show resolved Hide resolved
types/query/filtered-pagination.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #6514 into master will increase coverage by 0.04%.
The diff coverage is 77.41%.

@@            Coverage Diff             @@
##           master    #6514      +/-   ##
==========================================
+ Coverage   56.82%   56.86%   +0.04%     
==========================================
  Files         481      482       +1     
  Lines       28939    28999      +60     
==========================================
+ Hits        16445    16491      +46     
- Misses      11326    11333       +7     
- Partials     1168     1175       +7     

@anilcse anilcse requested a review from aaronc June 25, 2020 21:57
types/query/filtered_pagination.go Show resolved Hide resolved
types/query/filtered_pagination.go Show resolved Hide resolved
@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 1, 2020
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0f0723d into master Jul 1, 2020
@mergify mergify bot deleted the anil/filtered_pagination branch July 1, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants