Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/Slashing: gRPC query service #6597

Merged
merged 13 commits into from
Jul 6, 2020
Merged

x/Slashing: gRPC query service #6597

merged 13 commits into from
Jul 6, 2020

Conversation

sahith-narahari
Copy link
Contributor

Description

Ref: #5921


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #6597 into master will decrease coverage by 7.34%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #6597      +/-   ##
==========================================
- Coverage   57.66%   50.32%   -7.35%     
==========================================
  Files         493      242     -251     
  Lines       29621    13125   -16496     
==========================================
- Hits        17082     6605   -10477     
+ Misses      11314     6010    -5304     
+ Partials     1225      510     -715     

@aaronc aaronc mentioned this pull request Jul 3, 2020
43 tasks
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/slashing/keeper/grpc_query.go Show resolved Hide resolved
x/slashing/keeper/grpc_query.go Show resolved Hide resolved
x/slashing/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/slashing/keeper/grpc_query_test.go Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, +1 for the tests

proto/cosmos/slashing/query.proto Outdated Show resolved Hide resolved
proto/cosmos/slashing/query.proto Outdated Show resolved Hide resolved
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 6, 2020
@mergify mergify bot merged commit a0daec2 into master Jul 6, 2020
@mergify mergify bot deleted the sahith/5921-slashing-grpc branch July 6, 2020 21:54
@clevinson clevinson added this to the v0.40 [Stargate] milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/slashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants