Makefile: build simd with ledger support #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 7, 2020 17:29
Look for build options in the make's COSMOS_BUILD_OPTIONS variable. This allows one to build simd with ledger support. References: * cosmos/gaia#363 * tendermint/tendermint#4738
golangci-lint was not working correctly.
Codecov Report
@@ Coverage Diff @@
## master #6629 +/- ##
=======================================
Coverage 57.72% 57.72%
=======================================
Files 496 496
Lines 29731 29731
=======================================
Hits 17162 17162
Misses 11333 11333
Partials 1236 1236 |
alessio
requested review from
aaronc,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
jgimeno
approved these changes
Jul 7, 2020
fedekunze
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile: parse COSMOS_BUILD_OPTIONS
Look for build options in the make's COSMOS_BUILD_OPTIONS
variable. This allows one to build simd with ledger support.
References:
fix tiny typo in nolint: statement that causes golangci-lint to
misbehave.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes