Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump google.golang.org/protobuf from 1.24.0 to 1.25.0 #6891

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps google.golang.org/protobuf from 1.24.0 to 1.25.0.

Release notes

Sourced from google.golang.org/protobuf's releases.

v1.25.0

Overview

This release provides specialized support for well-known types.

Notable changes

New features:

Minor changes:

  • CL/238002: reflect/protoreflect: optimize Name.IsValid and FullName.IsValid
  • CL/239339: cmd/protoc-gen-go: use of --version flag exits with 0

Bug fixes:

  • CL/236998: encoding/protojson: strict validation of FieldMask serialization

Specialized support for well-known types

This release provides specialized support for well-known types by directly generating methods and functions into the generated package for certain well-known types that improve the usability of such types. The additionally generated APIs are listed below.

Upcoming breakage changes

There are no new upcoming breaking changes to announce in this release.

As a reminder, the following have already been announced and may take effect in the near future:

Commits
  • 3f7a61f all: release v1.25.0
  • 95ba8ac cmd/protoc-gen-go: --version should exit 0
  • 5a96da2 cmd/protoc-gen-go: generate package documentation for well-known types
  • b0c4001 all: update to cmp@v0.5.0 release
  • c0ad199 all: update to go1.13.12 and go1.14.4
  • c9c87ce internal/filedesc: use genid constants for map entry fields
  • 8de6675 test.bash: add staticcheck to our integration tests
  • 5f5c066 types/known: minor adjustments to error handling
  • a0d1c75 types/known: handle nil in IsValid and CheckValid methods
  • 44e4150 reflect/protoreflect: optimize Name.IsValid and FullName.IsValid
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file labels Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #6891 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6891   +/-   ##
=======================================
  Coverage   61.40%   61.40%           
=======================================
  Files         517      517           
  Lines       32050    32050           
=======================================
  Hits        19679    19679           
  Misses      10802    10802           
  Partials     1569     1569           

@@ -737,6 +738,8 @@ google.golang.org/protobuf v1.23.0/go.mod h1:EGpADcykh3NcUnDUJcl1+ZksZNG86OlYog2
google.golang.org/protobuf v1.23.1-0.20200526195155-81db48ad09cc/go.mod h1:EGpADcykh3NcUnDUJcl1+ZksZNG86OlYog2l/sGQquU=
google.golang.org/protobuf v1.24.0 h1:UhZDfRO8JRQru4/+LlLE0BRKGF8L+PICnvYZmx/fEGA=
google.golang.org/protobuf v1.24.0/go.mod h1:r/3tXBNzIEhYS9I1OUVjXDlt8tc493IdKGjtUeSXeh4=
google.golang.org/protobuf v1.25.0 h1:Ejskq+SyPohKW+1uil0JJMtmHCgJPJ/qWTxr8qp+R4c=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have so many version of protobuf here? which one is used when I do import "google.golang.org/protobuf"?

(sorry if it's a noob golang question)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to parse or read the sum file -- I don't really think you need to look at this ever. However, the go.mod tells you exactly the version that is being used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because some dependencies are probably using previous versions of protobuf

@mergify mergify bot merged commit 05c513e into master Jul 30, 2020
@mergify mergify bot deleted the dependabot/go_modules/google.golang.org/protobuf-1.25.0 branch July 30, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants