Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register x/mint gRPC gateway routes #7214

Merged
merged 7 commits into from
Sep 4, 2020

Conversation

mdaleem
Copy link
Contributor

@mdaleem mdaleem commented Sep 1, 2020

Description

ref: #5921
follow-up: #7019


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #7214 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7214      +/-   ##
==========================================
- Coverage   54.68%   54.66%   -0.03%     
==========================================
  Files         569      571       +2     
  Lines       39248    39297      +49     
==========================================
+ Hits        21463    21481      +18     
- Misses      16011    16039      +28     
- Partials     1774     1777       +3     

@anilcse anilcse changed the title Adds grpc tests for x/mint Register x/mint gRPC gateway routes Sep 1, 2020
@anilcse anilcse added C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. REST labels Sep 1, 2020
@aaronc aaronc mentioned this pull request Sep 1, 2020
43 tasks
@atheeshp atheeshp marked this pull request as ready for review September 3, 2020 11:18
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 3, 2020
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/mint/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 18ac096 into cosmos:master Sep 4, 2020
@mdaleem mdaleem deleted the grpc-gateway-x-mint branch April 19, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants