-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmovisor: various small improvements #7275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{,cosmosvisor/}Makefile: Add Makefile to cosmovisor/ subdirectory and integrate build target into the top-directory Makefile. cosmovisor/: Create Golang-idiomatic cmd/ subdirectory to make `cosmosvisor` binary (instead of a binary named `cmd`) automatically installable with `go get`. Minor changes to error handling: - Plain error strings bring more value than the whole stacktrace in case of dumb configuration errors. - Output errors to /dev/stderr instead of /dev/stdout.
alessio
requested review from
jgimeno,
amaury1093,
blushi,
clevinson,
tac0turtle,
sahith-narahari and
zmanian
September 10, 2020 12:43
Codecov Report
@@ Coverage Diff @@
## master #7275 +/- ##
=======================================
Coverage 55.15% 55.15%
=======================================
Files 584 584
Lines 40504 40504
=======================================
Hits 22340 22340
Misses 16290 16290
Partials 1874 1874 |
tac0turtle
reviewed
Sep 10, 2020
tac0turtle
reviewed
Sep 10, 2020
tac0turtle
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, one less dep 😄
faddat
approved these changes
Sep 10, 2020
faddat
approved these changes
Sep 10, 2020
faddat
approved these changes
Sep 10, 2020
sahith-narahari
approved these changes
Sep 10, 2020
fedekunze
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Sep 11, 2020
amaury1093
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{,cosmosvisor/}Makefile: Add Makefile to cosmovisor/
subdirectory and integrate build target into the
top-directory Makefile.
cosmovisor/:
Create Golang-idiomatic cmd/ subdirectory to make
cosmosvisor
binary (instead of a binary namedcmd
)automatically installable with
go get
.Minor changes to error handling:
Plain error strings bring more value than the whole
stacktrace in case of dumb configuration errors.
Output errors to /dev/stderr instead of /dev/stdout.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes