Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmovisor: various small improvements #7275

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 10, 2020

{,cosmosvisor/}Makefile: Add Makefile to cosmovisor/
subdirectory and integrate build target into the
top-directory Makefile.

cosmovisor/:

Create Golang-idiomatic cmd/ subdirectory to make
cosmosvisor binary (instead of a binary named cmd)
automatically installable with go get.

Minor changes to error handling:

  • Plain error strings bring more value than the whole
    stacktrace in case of dumb configuration errors.

  • Output errors to /dev/stderr instead of /dev/stdout.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

{,cosmosvisor/}Makefile: Add Makefile to cosmovisor/
subdirectory and integrate build target into the
top-directory Makefile.

cosmovisor/:

Create Golang-idiomatic cmd/ subdirectory to make
`cosmosvisor` binary (instead of a binary named `cmd`)
automatically installable with `go get`.

Minor changes to error handling:

- Plain error strings bring more value than the whole
  stacktrace in case of dumb configuration errors.

- Output errors to /dev/stderr instead of /dev/stdout.
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #7275 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7275   +/-   ##
=======================================
  Coverage   55.15%   55.15%           
=======================================
  Files         584      584           
  Lines       40504    40504           
=======================================
  Hits        22340    22340           
  Misses      16290    16290           
  Partials     1874     1874           

cosmovisor/args.go Outdated Show resolved Hide resolved
cosmovisor/args.go Outdated Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, one less dep 😄

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 11, 2020
@alessio alessio merged commit 32eccde into master Sep 11, 2020
@alessio alessio deleted the alessio/cosmovisor-fixes branch September 11, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants