Followup suggestions from ADR-027 updates (#7232) #7379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clevinson
requested review from
aaronc,
alessio and
alexanderbez
as code owners
aaronc
approved these changes
Sep 24, 2020
| @@ -12,20 +12,20 @@ Proposed | |||
| ## Abstract | |||
|
|
|||
| Fully deterministic structure serialization, which works across many languages and clients, | |||
| is needed for structure signature use-case. We need to be sure that whenever we serialize | |||
| is needed for the use case of structure signatures. We need to be sure that whenever we serialize | |||
There was a problem hiding this comment.
What are structure signatures. That's really not very clear
There was a problem hiding this comment.
Maybe is needed for generating a signature payload. ?
There was a problem hiding this comment.
How about is needed to sign a structure.?
There was a problem hiding this comment.
My reasoning was, Fully deterministic structure serialization is needed... to sign a struct, an array, a string, an integer, any kind of signature payload. I'm fine either way, I'll let you push a commit Robert, and we can merge this.
There was a problem hiding this comment.
Updated to "needed when signing messages". I hope that is more clear.
robert-zaremba
approved these changes
Sep 24, 2020
clevinson
commented
Sep 25, 2020
docs/architecture/adr-027-deterministic-protobuf-serialization.md
Outdated
Show resolved
Hide resolved
amaury1093
approved these changes
Sep 28, 2020
amaury1093
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Few grammatical fixes got missed in automerge.
ref: #7232
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes