Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for v0.42 #8900

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Fix docs for v0.42 #8900

merged 2 commits into from
Mar 17, 2021

Conversation

clevinson
Copy link
Contributor

Description

the docs/versions file needs to have a newline at end of file in order to get properly processed by the make build-docs command.

closes: #8890


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@lovincyrus lovincyrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it's the good o missing newline. lgtm 💯

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 17, 2021
@mergify mergify bot merged commit a9b73e6 into master Mar 17, 2021
@mergify mergify bot deleted the clevinson/0.42-docs branch March 17, 2021 08:53
@amaury1093
Copy link
Contributor

Oh wow, thanks @clevinson for finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: v0.42 isn't in gh-pages branch
4 participants