Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add markdownlint to lint commands #9353

Merged
merged 11 commits into from
May 27, 2021
Merged

chore: add markdownlint to lint commands #9353

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1709bc7
add markdownlint config
ryanchristo May 18, 2021
fcba745
update make lint commands
ryanchristo May 18, 2021
b3da891
update markdownlint config
ryanchristo May 21, 2021
4d40ccf
run make lint-fix
ryanchristo May 21, 2021
de2582a
fix empty link
ryanchristo May 21, 2021
676a11d
resuse docker container
ryanchristo May 21, 2021
40d6b65
run lint-fix
ryanchristo May 21, 2021
044fd8b
Merge branch 'master' into ryan/8112-markdownlint
ryanchristo May 24, 2021
c2ff689
do not echo commands
ryanchristo May 24, 2021
6217904
Merge branch 'master' into ryan/8112-markdownlint
ryanchristo May 25, 2021
7e688cd
Merge branch 'master' into ryan/8112-markdownlint
ryanchristo May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resuse docker container
  • Loading branch information
@ryanchristo
ryanchristo committed May 21, 2021
commit 676a11d01fcb19640b8fa8d5c17bf8d0f307c6fb
8 changes: 6 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,13 +326,17 @@ benchmark:
### Linting ###
###############################################################################

containerMarkdownLintImage=tmknom/markdownlint
containerMarkdownLint=cosmos-sdk-markdownlint
containerMarkdownLintFix=cosmos-sdk-markdownlint-fix

lint:
golangci-lint run --out-format=tab
docker run --rm -i -v "$(CURDIR):/work" tmknom/markdownlint
if docker ps -a --format '{{.Names}}' | grep -Eq "^${containerMarkdownLint}$$"; then docker start -a $(containerMarkdownLint); else docker run --name $(containerMarkdownLint) -i -v "$(CURDIR):/work" $(containerMarkdownLintImage); fi

lint-fix:
golangci-lint run --fix --out-format=tab --issues-exit-code=0
docker run --rm -i -v "$(CURDIR):/work" tmknom/markdownlint . --fix
if docker ps -a --format '{{.Names}}' | grep -Eq "^${containerMarkdownLintFix}$$"; then docker start -a $(containerMarkdownLintFix); else docker run --name $(containerMarkdownLintFix) -i -v "$(CURDIR):/work" $(containerMarkdownLintImage) . --fix; fi

.PHONY: lint lint-fix

Expand Down