Skip to content

Commit

Permalink
chore: updating adr version numbers and removing unnecessary comment …
Browse files Browse the repository at this point in the history
…in solomachine (#2969)
  • Loading branch information
damiannolan authored Dec 23, 2022
1 parent b697a6f commit 4e5c052
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/architecture/adr-006-02-client-refactor.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

## Status

Accepted and applied in v6 of ibc-go
Accepted and applied in v7 of ibc-go

## Context

Expand Down
4 changes: 2 additions & 2 deletions docs/architecture/adr-007-solomachine-signbytes.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

## Status

Accepted, applied in v6
Accepted, applied in v7

## Context

The `06-solomachine` implemention up until ibc-go v6 constructed sign bytes using a `DataType` which described what type of data was being signed.
The `06-solomachine` implemention up until ibc-go v7 constructed sign bytes using a `DataType` which described what type of data was being signed.
This design decision arose from a misunderstanding of the security implications.
It was noted that the proto definitions do not [provide uniqueness](https://github.com/cosmos/cosmos-sdk/pull/7237#discussion_r484264573) which is a necessity for ensuring two signatures over different data types can never be the same.
What was missed is that the uniqueness is not provided by the proto definition, but by the usage of the proto definition.
Expand Down
1 change: 0 additions & 1 deletion modules/light-clients/06-solomachine/client_state.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ func NewClientState(latestSequence uint64, consensusState *ConsensusState) *Clie
Sequence: latestSequence,
IsFrozen: false,
ConsensusState: consensusState,
// AllowUpdateAfterProposal has been DEPRECATED. See 01_concepts in the solo machine spec repo for more details.
}
}

Expand Down

0 comments on commit 4e5c052

Please sign in to comment.