Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Default ProofSpecs for SDK SMT change #559

Closed
AdityaSripal opened this issue Nov 24, 2021 · 5 comments
Closed

Change Default ProofSpecs for SDK SMT change #559

AdityaSripal opened this issue Nov 24, 2021 · 5 comments
Assignees

Comments

@AdityaSripal
Copy link
Member

When the SDK SMT change comes in, we'll have to change our default proofspecs to reflect the new proofspecs for SDK chains.

This would involve changing the following line:
https://github.com/cosmos/ibc-go/blob/main/modules/core/23-commitment/types/merkle.go#L17

to SMTSpec, TendermintSpec

and then testing the combined SDK/IBC changes

@crodriguezvega crodriguezvega added this to the v3.0.0 milestone Nov 24, 2021
@crodriguezvega crodriguezvega modified the milestones: v3.0.0, v5.0.0 Dec 16, 2021
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jan 6, 2022

@AdityaSripal I think at the moment hermes is using these default proof specs in the MsgCreateClient that creates the light client. With the upcoming SMTSpec, will the hermes relayer need to implement and use this new spec when creating the light client for a chain that supports SMTSpec and TendermintSpec?

@AdityaSripal
Copy link
Member Author

We need to implement a query that is available on all chains so that relayers can simply query the chain to determine what proof specs to use for the client. cc: @colin-axner

faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@robert-zaremba
Copy link

Why there is a default proof spec? Shoudn't that be implied by the SDK / IBC config? Default sounds dangerous here - what if someone will forget to configure?

@crodriguezvega
Copy link
Contributor

Thanks for the comment, @robert-zaremba. Yes, I guess you're right and it would be more flexible if ibc-go could dynamically figure out what proof specs to use. @AdityaSripal, any idea if this could be feasible?

@damiannolan
Copy link
Member

can we close this? IIRC sdk do not plan to migrate away from iavl anytime soon?

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
Bumps [github.com/dgraph-io/badger/v3](https://github.com/dgraph-io/badger) from 3.2103.2 to 3.2103.3.
- [Release notes](https://github.com/dgraph-io/badger/releases)
- [Changelog](https://github.com/dgraph-io/badger/blob/v3.2103.3/CHANGELOG.md)
- [Commits](dgraph-io/badger@v3.2103.2...v3.2103.3)

---
updated-dependencies:
- dependency-name: github.com/dgraph-io/badger/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🥳
Development

No branches or pull requests

4 participants