fixed switch-case; added test cases

modules/core/keeper/keeper.go

@@ -54,7 +54,7 @@ func NewKeeper(
 	// switch case to detect blank pointers
 	switch reflect.TypeOf(stakingKeeper).Kind() {
 	case reflect.Ptr:
-		if reflect.ValueOf(&stakingKeeper).IsZero() {
+		if reflect.ValueOf(stakingKeeper).Elem().IsZero() {
 			panic(fmt.Errorf("cannot initialize IBC keeper: empty staking keeper pointer"))
 		}
 	default:
@@ -65,7 +65,7 @@ func NewKeeper(
 
 	switch reflect.TypeOf(upgradeKeeper).Kind() {
 	case reflect.Ptr:
-		if reflect.ValueOf(&upgradeKeeper).IsZero() {
+		if reflect.ValueOf(upgradeKeeper).Elem().IsZero() {
 			panic(fmt.Errorf("cannot initialize IBC keeper: empty upgrade keeper pointer"))
 		}
 	default:

modules/core/keeper/keeper_test.go

@@ -79,21 +79,31 @@ func (suite *KeeperTestSuite) TestNewKeeper() {
 		malleate func()
 		expPass  bool
 	}{
-		{"failure: empty staking keeper", func() {
-			emptyStakingKeeper := stakingkeeper.Keeper{}
+		{"failure: empty staking keeper value", func() {
+			emptyStakingKeeperValue := stakingkeeper.Keeper{}
 
-			stakingKeeper = emptyStakingKeeper
+			stakingKeeper = emptyStakingKeeperValue
+		}, false},
+		{"failure: empty staking keeper pointer", func() {
+			emptyStakingKeeperPointer := &stakingkeeper.Keeper{}
+
+			stakingKeeper = emptyStakingKeeperPointer
 		}, false},
 		{"failure: empty mock staking keeper", func() {
 			// use a different implementation of clienttypes.StakingKeeper
 			emptyMockStakingKeeper := MockStakingKeeper{}
 
 			stakingKeeper = emptyMockStakingKeeper
 		}, false},
-		{"failure: empty upgrade keeper", func() {
-			emptyUpgradeKeeper := upgradekeeper.Keeper{}
+		{"failure: empty upgrade keeper value", func() {
+			emptyUpgradeKeeperValue := upgradekeeper.Keeper{}
+
+			upgradeKeeper = emptyUpgradeKeeperValue
+		}, false},
+		{"failure: empty upgrade keeper pointer", func() {
+			emptyUpgradeKeeperPointer := &upgradekeeper.Keeper{}
 
-			upgradeKeeper = emptyUpgradeKeeper
+			upgradeKeeper = emptyUpgradeKeeperPointer
 		}, false},
 		{"failure: empty scoped keeper", func() {
 			emptyScopedKeeper := capabilitykeeper.ScopedKeeper{}