Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chains that can't introspect their own ConsensusState support IBC #2419

Merged
merged 7 commits into from
Dec 27, 2022

Conversation

seunlanlege
Copy link
Contributor

@seunlanlege seunlanlege changed the title Allow chains that can't introspect their own consensus state support IBC Allow chains that can't introspect their own ConsensusState support IBC Sep 28, 2022
proto/ibc/core/connection/v1/tx.proto Outdated Show resolved Hide resolved
proto/ibc/core/connection/v1/tx.proto Outdated Show resolved Hide resolved
proto/ibc/core/connection/v1/tx.proto Outdated Show resolved Hide resolved
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seunlanlege

@crodriguezvega crodriguezvega merged commit 48efd8e into cosmos:main Dec 27, 2022
@en
Copy link

en commented Jul 7, 2023

Hi @seunlanlege and @AdityaSripal,
Why don't we define this field as optional? I think the cosmos-sdk based chain should not need this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants