refactor(simapp): use app v2 for core sdk modules #4334
Conversation
testing/simapp/simd/cmd/root.go
Outdated
There was a problem hiding this comment.
It will look so much nicer when IBC modules use depinject.
| ) | ||
| if err != nil { | ||
| panic(err) | ||
| // AutoCliOpts returns the autocli options for the app. |
There was a problem hiding this comment.
This can be depinjected when IBC fully uses app v2.
julienrbrt
requested review from
AdityaSripal,
charleenfei,
colin-axner,
damiannolan,
crodriguezvega,
chatton and
DimitrisJim
as code owners
|
Looks great @julienrbrt, if I have some extra time I might push some commits to this if that's cool? Would be great to see if we could get e2e's running with this, but now that I think of it, I think we may still be waiting on interchaintest v0.50 compat. |
|
This is very useful; thank you very much, @julienrbrt! I had a quick look and was thinking if there was a reason why you replaced the legacy app.go with the v2 one, instead of keeping the legacy and adding an app_v2.go, as you are doing in the SDK. What are you plans for the legacy app.go in the SDK? |
The idea is that given that we verify the manual wiring of the SDK modules directly in the SDK, you do not need to do it here too. I guess once you fully use depinject for your app v2 it will make sense to do the same as the SDK for the IBC modules. |
|
Love this. Thank you @julienrbrt ! |
|
Looks like the pr got automatically closed after meging the feature branch. I'm not able to reopen or rebase. You can reopen against main |
|
Sure, will do. |
Description
Spike, feel free to merge if the IBC team find that useful.
This PR makes the Core SDK Modules use app wiring. Given that IBC modules do not support app wiring yet, this is then an example of a mixed configuration.
The advantage for IBC to have such mixed app.go, is still to benefit of app v2 from the Cosmos SDK modules, and hence a smaller app.go; as well as not having any breaking change in app wiring for Core SDK module in the future.
As well as demonstrating other app developers how to use a mixed app v2 (we have docs https://docs.cosmos.network/main/building-apps/app-go-v2#registering-non-app-wiring-modules, but this can still be a good reference) until you migrate.
Commit Message / Changelog Entry
refactor(simapp): use app v2 for core sdk modulessee the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.