Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themis 0.13.4 #736

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Themis 0.13.4 #736

merged 3 commits into from
Oct 28, 2020

Conversation

ilammy
Copy link
Collaborator

@ilammy ilammy commented Oct 28, 2020

Cut the next hotfix for Apple platforms, updating the OpenSSL dependency which should resolve most of the newly found issues with Apple Silicon support and deploying applications to the App Store.

@vixentael, please review the changelog updates and other things.

I've already cherry-picked all those changes from master into release/0.13 and tested them. I've also merged CI changes from stable with fixes for Xcode 12 support and non-Apple builds. Carthage and CocoaPods configurations should be the same as in master, except for version updates performed in this PR.

Running the CI tests is going to take a while, since there are a lot of pushes pending. I think we might be able to merge this today(ish)—maybe at 26:23 😂 However, I'd expect the proper GitHub release to be performed tomorrow, after testing the published version on devices, so I'm dating it with October 29th in the changelog.

Provisional 0.13.4 tag has been already pushed to the repository to allow CocoaPods spec linting. It points to the tip of this PR. After this PR is merged, I'll update the tag to the proper commit and sign it. (As per the release process.)

Checklist

  • Change is covered by automated tests
  • The coding guidelines are followed
  • Example projects and code samples are up-to-date (this will be done in a separate PR)
  • Changelog is updated (mark after review)

Cut the next hotfix for Apple platforms, updating the OpenSSL dependency
which should resolve most of the newly found issues with Apple Silicon
support and deploying applications to the App Store.
They have been kept separate because of the way cherry-picking from
master branch works. However, since Themis 0.13.4 changelog contains
only identical changes for Objective-C and Swift, merge the sections
into a single combined one to keep it short.
@ilammy ilammy added O-iOS 📱 Operating system: iOS release O-macOS 💻 Operating system: macOS W-SwiftThemis 🔶 Wrapper: SwiftThemis, Swift API W-ObjCThemis 🎨 Wrapper: ObjCThemis, Objective-C API M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS labels Oct 28, 2020
@ilammy ilammy requested a review from Lagovas as a code owner October 28, 2020 18:55
Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I <3 Apple no, not really. I hope that Xcode 12.2 stable will be very close to the current Xcode 12.2 beta, and all our troubles with OpenSSL won't need to be re-done.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: vixentael <vixentael@users.noreply.github.com>
@ilammy ilammy merged commit 718e7ba into release/0.13 Oct 28, 2020
@ilammy ilammy deleted the ilammy/themis-0.13.4 branch October 28, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS M-CocoaPods Package manager: CocoaPods, Objective-C and Swift, iOS and macOS O-iOS 📱 Operating system: iOS O-macOS 💻 Operating system: macOS release W-ObjCThemis 🎨 Wrapper: ObjCThemis, Objective-C API W-SwiftThemis 🔶 Wrapper: SwiftThemis, Swift API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants