Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

By default, it should adapt to the system's colorScheme setting #11

Closed
dkk opened this issue Feb 8, 2021 · 0 comments
Closed

By default, it should adapt to the system's colorScheme setting #11

dkk opened this issue Feb 8, 2021 · 0 comments

Comments

@dkk
Copy link
Contributor

dkk commented Feb 8, 2021 •
edited
Loading

Right now, .lightis used as the default colorScheme. Instead, the colorScheme should be taken from the system's colorScheme setting. Otherwise, when using the library, you have to make sure that Neumorphic's colorScheme updates with the system's colorScheme manually.

@Environment(\.colorScheme) can be used for that.
@dkk dkk changed the title By default, it should addapt to the system's colorScheme setting By default, it should adapt to the system's colorScheme setting Feb 8, 2021
dkk added a commit to dkk/neumorphic that referenced this issue Feb 8, 2021
@dkk
Merge pull request #1 from dkk/feature/automatic-colorScheme-update
4f16b8f 
Resolves costachung#11: Take the colorScheme from the system automatically
costachung added a commit that referenced this issue Feb 9, 2021
@costachung
Merge pull request #12 from dkk/feature/automatic-colorScheme-update
7ff9913 
Resolves #11: Take the colorScheme from the system automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkk