Skip to content

Commit

Permalink
Fixed #47 for real.
Browse files Browse the repository at this point in the history
  • Loading branch information
andris-sevcenko committed Mar 27, 2019
1 parent dbe4687 commit a5d912d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
### Added
- Added the `makeUploadsPublic` setting which defaults to true and determines whether the uploaded Assets are public on the bucket. ([#48](https://github.com/craftcms/aws-s3/issues/48))

### Fixed
- Fixed an error that could occur when installing the plugin on a site that was migrated from Craft 2. ([#47](https://github.com/craftcms/aws-s3/issues/47))

## 1.2.1 - 2019-03-05

### Changed
Expand Down
4 changes: 4 additions & 0 deletions src/migrations/Install.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ private function _convertVolumes()
$settings['region'] = $settings['location'];
unset($settings['urlPrefix'], $settings['location'], $settings['storageClass']);

if (preg_match('/^([\d]+)([a-z]+)$/', $settings['expires'], $matches)) {
$settings['expires'] = $matches[1] . ' ' . $matches[2];
}

$volume['url'] = $url;
$volume['settings'] = $settings;

Expand Down

0 comments on commit a5d912d

Please sign in to comment.