Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pullrequests/love to know/fix focal subfolder env #87

Merged
merged 2 commits into from
May 29, 2020
Merged

Pullrequests/love to know/fix focal subfolder env #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
569df6d
Fix bug where focal point detection will fail if the volume subfolder…
JoshCoady May 27, 2020
8eedad1
Changelog.
andris-sevcenko May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Release Notes for Amazon S3 for Craft CMS

## Unreleased

### Fixed
- Fixed a bug where focal point detection would not work if aliases were used in the subfolder setting. ([#86](https://github.com/craftcms/aws-s3/pull/86))

## 1.2.8 - 2020-05-18

### Added
Expand Down
2 changes: 1 addition & 1 deletion src/Volume.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ public function detectFocalPoint(string $filePath): array
$params = [
'Image' => [
'S3Object' => [
'Name' => $filePath,
'Name' => Craft::parseEnv($filePath),
'Bucket' => Craft::parseEnv($this->bucket),
],
],
Expand Down