Skip to content

Commit

Permalink
[java] Cleanup after migration to JUnit 5 (SeleniumHQ#10793)
Browse files Browse the repository at this point in the history
Final cleanup in Bazel config after migration to JUnit 5. This PR also
includes a fix in a test (not being executed)

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
  • Loading branch information
bonigarcia and diemol committed Jun 22, 2022
1 parent 3e8f94c commit 6e87b08
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 26 deletions.
24 changes: 0 additions & 24 deletions java/private/library.bzl
Original file line number Diff line number Diff line change
@@ -1,34 +1,10 @@
load("@apple_rules_lint//lint:defs.bzl", "get_lint_config")
load(
"@contrib_rules_jvm//java:defs.bzl",
"spotbugs_test",
_java_library = "java_library",
_java_test = "java_test",
)
load(":export.bzl", _java_export = "java_export")

def add_lint_tests(name, **kwargs):
srcs = kwargs.get("srcs", [])

if len(srcs) == 0:
return

tags = kwargs.get("tags", [])

spotbugs = get_lint_config("java-spotbugs", tags)
if spotbugs != None:
spotbugs_test(
name = "%s-spotbugs" % name,
config = spotbugs,
only_output_jars = True,
deps = [
":%s" % name,
],
tags = tags + ["lint", "java-spotbugs"],
size = "small",
timeout = "moderate",
)

java_export = _java_export
java_library = _java_library
java_test = _java_test
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public void testPopulationOfSessionLog() throws IOException {
}

@Test
@Ignore("it fails!")
@Disabled("it fails!")
public void testLoggedSessions() {
PerSessionLogHandler handler = createPerSessionLogHandler();
SessionId sessionId = new SessionId("session-1");
Expand All @@ -61,7 +61,7 @@ public void testLoggedSessions() {
}

@Test
@Ignore("it fails!")
@Disabled("it fails!")
public void testGetSessionLogsWithLogCaptureDisabled() {
PerSessionLogHandler handler = createPerSessionLogHandler();
SessionId sessionId = new SessionId("session-1");
Expand Down

0 comments on commit 6e87b08

Please sign in to comment.