Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coolix unit test errors when using Apple c++ compiler. #1030

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

crankyoldgit
Copy link
Owner

  • Possible difference in behaviour between g++ & Apple's c++ memory
    initialisation.

FYI @egueli
Fixes #1028

- Possible difference in behaviour between g++ & Apple's c++ memory 
initialisation.

FYI @egueli
Fixes #1028
@crankyoldgit
Copy link
Owner Author

Confirmed working in #1028 (comment)

@crankyoldgit crankyoldgit merged commit edd4abb into master Jan 27, 2020
@crankyoldgit crankyoldgit deleted the Issue1028 branch January 29, 2020 08:48
crankyoldgit added a commit that referenced this pull request Jan 30, 2020
_v2.7.3 (20200130)_

**[Features]**
- Allow protocols to be enabled or disabled with compiler flags. (#1013, #1012)
- Panasonic AC: Add Ion Filter support for DKE models. (#1025, #1024)
- Add support for sending Sony at 38Khz (#1029, #1018, #1019)
- auto_analyse_raw_data.py: Handle analysing messages with no headers. (#1017)

**[Misc]**
- Fix Coolix unit test errors when using Apple c++ compiler. (#1030, #1028)
- Fix Apple clang c++ compiler error in unit tests. (#1027, #1026)
- Improve/fix scraping of supported devices (#1022)
- Panasonic PKR series A/C uses DKE protocol. (#1020, #1021)
- Update NEC supported devices. (#1018)
- Add note to avoid GPIO16 on the ESP8266 for receiving. (#1016, #1015)
@crankyoldgit crankyoldgit mentioned this pull request Jan 30, 2020
crankyoldgit added a commit that referenced this pull request Jan 30, 2020
_v2.7.3 (20200130)_

**[Features]**
- Allow protocols to be enabled or disabled with compiler flags. (#1013, #1012)
- Panasonic AC: Add Ion Filter support for DKE models. (#1025, #1024)
- Add support for sending Sony at 38Khz (#1029, #1018, #1019)
- auto_analyse_raw_data.py: Handle analysing messages with no headers. (#1017)

**[Misc]**
- Fix Coolix unit test errors when using Apple c++ compiler. (#1030, #1028)
- Fix Apple clang c++ compiler error in unit tests. (#1027, #1026)
- Improve/fix scraping of supported devices (#1022)
- Panasonic PKR series A/C uses DKE protocol. (#1020, #1021)
- Update NEC supported devices. (#1018)
- Add note to avoid GPIO16 on the ESP8266 for receiving. (#1016, #1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing unit test TestCoolixACClass.toCommon
1 participant