Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Doshisha LED light protocol #1115

Merged
merged 3 commits into from
May 12, 2020
Merged

Add support for Doshisha LED light protocol #1115

merged 3 commits into from
May 12, 2020

Conversation

NiKiZe
Copy link
Collaborator

@NiKiZe NiKiZe commented May 12, 2020

Implements #1114

@crankyoldgit crankyoldgit self-requested a review May 12, 2020 05:35
crankyoldgit
crankyoldgit approved these changes May 12, 2020
View reviewed changes
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NiKiZe Looks good to me!

You might want run tools/scrape_supported_devices.py from the top directory. (Requires Python3)
(after you git pull) to complete your masterful job!

Congrats.

Now that you understand it all, do you want to be an official "Collaborator"? If so, I can grant you access and you can merge it yourself! :)

@crankyoldgit
Copy link
Owner

P.S. \o/ for unit tests!! <swoon>

@NiKiZe
Copy link
Collaborator Author

NiKiZe commented May 12, 2020

A question about the update caused by scrape_supported_devices.py

When there is multiple PRs in progress this is guaranteed to create conflicts, wouldn't it be better to run that once as part of the release process?

In regards to "Collaborator", Thanks, but I think it is better if I refrain from that for a while more.

@crankyoldgit
Copy link
Owner

crankyoldgit commented May 12, 2020 •
edited
Loading

In regards to "Collaborator", Thanks, but I think it is better if I refrain from that for a while more.

You don't have to exercise your "power" if you don't want to. However, it does enable me to send "code reviews" your way. Accept it or not. Completely up to you! ;-)

When there is multiple PRs in progress this is guaranteed to create conflicts, wouldn't it be better to run that once as part of the release process?

Often, yes. But this is what merge and rebase are for. You'll be in first so it doesn't matter to you. ;-)

@NiKiZe
Run scrape_supported_devices.py Doshisha
c453be1 
* SupportedProtocols.md update
** Doshisha added
** Sharp changes from previous commits
@NiKiZe
Copy link
Collaborator Author

NiKiZe commented May 12, 2020

For the sake of reviews, ok.

I love rebase, (a bit to much at times), but dislike squash merge :D
But still would like to not see conflicts if possible (it has caused issues in the past correct ;))
Therefore the question of if it wouldn't be better to do it as part of release process. (maybe it would be great to implement a dry-run option to it and have it run as part of travis and precommit checks to ensure that Model styling is correct in all ir_*.cpp files)

@crankyoldgit
Copy link
Owner

I love rebase, (a bit to much at times), but dislike squash merge :D

I only like squash merge for when a PR is ready to go into the master branch. i.e. A single commit.

Therefore the question of if it wouldn't be better to do it as part of release process.

It is part of that process. ;-)

I was mainly pushing/suggesting you do it for the "100%" full marks for your PR. ;-)

@crankyoldgit crankyoldgit merged commit 8a93475 into crankyoldgit:master May 12, 2020
@crankyoldgit crankyoldgit mentioned this pull request May 12, 2020
Closed
crankyoldgit added a commit that referenced this pull request May 19, 2020
@crankyoldgit
v2.7.7 release
01a555b 
_v2.7.7 (20200519)_

**[BREAKING CHANGES]**
- Fix Symphony protocol. (#1107, #1105)
  * Now 12 bits and bits are inverted. All previous codes will no longer work.
- IRMQTTServer: Better handle power & mode operations for Home Assistant. (#1099, #1092)
  * When `MQTT_CLIMATE_HA_MODE` is enabled (default) this will break previous operation mode resumption when power is changed.

**[Bug Fixes]**
- Set correct return type for `.calibrate()` (#1095, #1093)

**[Features]**
- Add basic support for Carrier 40 & 64 bit protocols. (#1125, @1112, #1127)
- Gree: Enable native support for Fahrenheit (#1124, #1121)
- Gree: Add option to control display temp source. (#1120, #1118)
- Add support for Multibrackets protocol. (#1106, #1103)
- Add RawToPronto.py tool & improve `sendPronto()` precision (#1104, #1103)
- Add support for `Doshisha` LED light protocol (#1115)
- Introduce IRrecvDumpV3 with basic OTA update support (#1111)
- Add detailed support for Delonghi A/C (#1098, #1096)
- Improved support for SharpAc. (#1094, #1091)
- Update auto_analyse to use new decode call structure. (#1102, #1097)
- Added Blynk app example (#1090)
@crankyoldgit crankyoldgit mentioned this pull request May 19, 2020
Merged
crankyoldgit added a commit that referenced this pull request May 19, 2020
@crankyoldgit
v2.7.7 release
e2a8674 
_v2.7.7 (20200519)_

**[BREAKING CHANGES]**
- Fix Symphony protocol. (#1107, #1105)
  * Now 12 bits and bits are inverted. All previous codes will no longer work.
- IRMQTTServer: Better handle power & mode operations for Home Assistant. (#1099, #1092)
  * When `MQTT_CLIMATE_HA_MODE` is enabled (default) this will break previous operation mode resumption when power is changed.

**[Bug Fixes]**
- Set correct return type for `.calibrate()` (#1095, #1093)

**[Features]**
- Add basic support for Carrier 40 & 64 bit protocols. (#1125, @1112, #1127)
- Gree: Enable native support for Fahrenheit (#1124, #1121)
- Gree: Add option to control display temp source. (#1120, #1118)
- Add support for Multibrackets protocol. (#1106, #1103)
- Add RawToPronto.py tool & improve `sendPronto()` precision (#1104, #1103)
- Add support for `Doshisha` LED light protocol (#1115)
- Introduce IRrecvDumpV3 with basic OTA update support (#1111)
- Add detailed support for Delonghi A/C (#1098, #1096)
- Improved support for SharpAc. (#1094, #1091)
- Update auto_analyse to use new decode call structure. (#1102, #1097)
- Added Blynk app example (#1090)

**[Misc]**
- update auto_analyse script to use new param documentation (#1126)
- Improve `raw_to_pronto_code.py` (#1122, #1103)
- Use pattern rules in Makefiles to reduce specific rule (#1110)
- Update list of supported Daikin models. (#1101)
crankyoldgit added a commit that referenced this pull request May 19, 2020
@crankyoldgit
v2.7.7 release
e69a119 
_v2.7.7 (20200519)_

**[BREAKING CHANGES]**
- Fix Symphony protocol. (#1107, #1105)
  * Now 12 bits and bits are inverted. All previous codes will no longer work.
- IRMQTTServer: Better handle power & mode operations for Home Assistant. (#1099, #1092)
  * When `MQTT_CLIMATE_HA_MODE` is enabled (default) this will break previous operation mode resumption when power is changed.

**[Bug Fixes]**
- Set correct return type for `.calibrate()` (#1095, #1093)

**[Features]**
- Add basic support for Carrier 40 & 64 bit protocols. (#1125, #1112, #1127)
- Gree: Enable native support for Fahrenheit (#1124, #1121)
- Gree: Add option to control display temp source. (#1120, #1118)
- Add support for Multibrackets protocol. (#1106, #1103)
- Add RawToPronto.py tool & improve `sendPronto()` precision (#1104, #1103)
- Add support for `Doshisha` LED light protocol (#1115)
- Introduce IRrecvDumpV3 with basic OTA update support (#1111)
- Add detailed support for Delonghi A/C (#1098, #1096)
- Improved support for SharpAc. (#1094, #1091)
- Update auto_analyse to use new decode call structure. (#1102, #1097)
- Added Blynk app example (#1090)

**[Misc]**
- update auto_analyse script to use new param documentation (#1126)
- Improve `raw_to_pronto_code.py` (#1122, #1103)
- Use pattern rules in Makefiles to reduce specific rule (#1110)
- Update list of supported Daikin models. (#1101)
crankyoldgit added a commit that referenced this pull request May 20, 2020
@crankyoldgit
v2.7.7 release (#1132)
691a05d 
_v2.7.7 (20200519)_

**[BREAKING CHANGES]**
- Fix Symphony protocol. (#1107, #1105)
  * Now 12 bits and bits are inverted. All previous codes will no longer work.
- IRMQTTServer: Better handle power & mode operations for Home Assistant. (#1099, #1092)
  * When `MQTT_CLIMATE_HA_MODE` is enabled (default) this will break previous operation mode resumption when power is changed.

**[Bug Fixes]**
- Set correct return type for `.calibrate()` (#1095, #1093)

**[Features]**
- Add basic support for Carrier 40 & 64 bit protocols. (#1125, #1112, #1127)
- Gree: Enable native support for Fahrenheit (#1124, #1121)
- Gree: Add option to control display temp source. (#1120, #1118)
- Add support for Multibrackets protocol. (#1106, #1103)
- Add RawToPronto.py tool & improve `sendPronto()` precision (#1104, #1103)
- Add support for `Doshisha` LED light protocol (#1115)
- Introduce IRrecvDumpV3 with basic OTA update support (#1111)
- Add detailed support for Delonghi A/C (#1098, #1096)
- Improved support for SharpAc. (#1094, #1091)
- Update auto_analyse to use new decode call structure. (#1102, #1097)
- Added Blynk app example (#1090)

**[Misc]**
- update auto_analyse script to use new param documentation (#1126)
- Improve `raw_to_pronto_code.py` (#1122, #1103)
- Use pattern rules in Makefiles to reduce specific rule (#1110)
- Update list of supported Daikin models. (#1101)
@crankyoldgit
Copy link
Owner

FYI, the changes mentioned above have now been included in the latest release (v2.7.7) of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crankyoldgit crankyoldgit crankyoldgit approved these changes

Assignees

@NiKiZe NiKiZe

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiKiZe @crankyoldgit