[Bug] Ensure begin() is called for every supported common a/c.
#905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some protocols didn't call `begin()`. Fixed. Moved all the calls to inside their respective procedures. Fixes #899
crankyoldgit
requested review from
sillyfrog,
rahuljawale,
darshkpatel and
markszabo
crankyoldgit
added a commit
that referenced
this pull request
Sep 23, 2019
_v2.6.6 (20190923)_ **[Bug Fixes]** - Ensure `begin()` is called for every supported common a/c. (#905, #899) - IRMQTTServer: Fix JSON state parsing. (#896) - IRMQTTServer: Fix compilation error when `MQTT_CLIMATE_JSON` is `true`. (#893) **[Features]** - Mitsubishi136: Full A/C support. (#898, #890) - Fujitsu: Add support for ARRY4 remote. (#895) - Web-AC-control: Add new WebUI example sketch. (#880, #886) - Improve Common A/C API (#913) - IRMQTTServer: Support for multiple climates. (#903) - IRMQTTServer: Add TX channel support for HTTP interface. (#929) - IRMQTTServer: Add option to clear retained settings. (#917) - auto_analyse_raw_data.py: Add decode code generation. (#909) - auto_analyse_raw_data.py: General improvements (#906) **[Misc]** - IRMQTTServer: Use latest API for common A/C. (#928) - IRMQTTServer: Add flag & documentation for Home Assistant mode. (#919) - IRMQTTServer: Move from ArduinoJson v5 to v6. (#878) - IRMQTTServer: Use retain for discovery message. (#881) - Goodweather: Adjust timings & minor fixes. (#924) - PanasonicAc: Add better SwingV support for common a/c framework. (#923) - Daikin2: Corrections for common A/C interface. (#910) - MitsubishiAC: Improve decoding. (#914) - Fujitsu: Disable horiz swing for ARRY4. (#907) - SamsungAc: Only send power on/off code if it's needed. (#884) - Teco: Add timer support. (#883) - More consistent A/C `::toString()` output. (#920)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Sep 23, 2019
_v2.6.6 (20190923)_ **[Bug Fixes]** - Ensure `begin()` is called for every supported common a/c. (#905, #899) - IRMQTTServer: Fix JSON state parsing. (#896) - IRMQTTServer: Fix compilation error when `MQTT_CLIMATE_JSON` is `true`. (#893) **[Features]** - Mitsubishi136: Full A/C support. (#898, #890) - Fujitsu: Add support for ARRY4 remote. (#895) - Web-AC-control: Add new WebUI example sketch. (#880, #886) - Improve Common A/C API (#913) - IRMQTTServer: Support for multiple climates. (#903) - IRMQTTServer: Add TX channel support for HTTP interface. (#929) - IRMQTTServer: Add option to clear retained settings. (#917) - auto_analyse_raw_data.py: Add decode code generation. (#909) - auto_analyse_raw_data.py: General improvements (#906) **[Misc]** - IRMQTTServer: Use latest API for common A/C. (#928) - IRMQTTServer: Add flag & documentation for Home Assistant mode. (#919) - IRMQTTServer: Move from ArduinoJson v5 to v6. (#878) - IRMQTTServer: Use retain for discovery message. (#881) - Goodweather: Adjust timings & minor fixes. (#924) - PanasonicAc: Add better SwingV support for common a/c framework. (#923) - Daikin2: Corrections for common A/C interface. (#910) - MitsubishiAC: Improve decoding. (#914) - Fujitsu: Disable horiz swing for ARRY4. (#907) - SamsungAc: Only send power on/off code if it's needed. (#884) - Teco: Add timer support. (#883) - More consistent A/C `::toString()` output. (#920)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some protocols didn't call
begin(). Fixed.Moved all the calls to inside their respective procedures.
Fixes #899