Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable format assertions for optional/ecmascript-regex.json #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable format assertions for optional/ecmascript-regex.json #191

wants to merge 1 commit into from

Conversation

justin-tay
Copy link
Contributor

Closes #190

This enabled format assertions for optional/ecmascript-regex.json as the \\a is not an ECMA 262 control escape test is a format "format": "regex" that expects the result to be invalid.

This also upgrades com.networknt:json-schema-validator to 1.4.2 as this version passes the "format": "regex" test.

@justin-tay justin-tay requested a review from a team as a code owner June 21, 2024 04:50
@big-andy-coates
Copy link
Member

Hopefully some of this change isn't needed if json-schema-org/JSON-Schema-Test-Suite#751 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format assertions should be enabled for optional/ecmascript-regex.json
2 participants
@justin-tay @big-andy-coates