Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add initial deposit ratio requirement of 0.5 for proposal submission #2

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

crypin
Copy link
Member

@crypin crypin commented Feb 17, 2023

Description

The MinInitialDepositRatio is set to 0.5, which verifies that the initial deposition is more than 50% of the params.MinDeposit when submitting the proposal.

MinInitialDepositRatio was added as a parameter in cosmos#12771
We also need the function, but it has not been released yet, so we added it by hardcoding it to 0.5 instead of param.
The reason why it is not added to the parameter is to minimize store migration to reduce upgrade complexity and preserve the original params structure.

Ref


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@richard-bachman richard-bachman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for drafting. Please see my comments.

x/gov/keeper/msg_server.go Show resolved Hide resolved
x/gov/keeper/msg_server.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants