Skip to content

Commit

Permalink
[Discover] Unskip esql view tests (elastic#196677)
Browse files Browse the repository at this point in the history
- Closes elastic#194305
- Closes elastic#194425
- Closes elastic#194482
  • Loading branch information
jughosta authored Oct 18, 2024
1 parent 6bb2d77 commit f8c4b9a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions test/functional/apps/discover/esql/_esql_view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('should not show switch modal when switching to a data view while a saved search is open', async () => {
await discover.selectTextBaseLang();
await header.waitUntilLoadingHasFinished();
await discover.waitUntilSearchingHasFinished();
const testQuery = 'from logstash-* | limit 100 | drop @timestamp';
await monacoEditor.setCodeEditorValue(testQuery);
await testSubjects.click('querySubmitButton');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
defaultIndex: 'logstash-*',
};

// Failing: See https://github.com/elastic/kibana/issues/194305
describe.skip('discover esql view', function () {
describe('discover esql view', function () {
// see details: https://github.com/elastic/kibana/issues/188816
this.tags(['failsOnMKI']);

Expand Down Expand Up @@ -275,6 +274,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('should not show switch modal when switching to a data view while a saved search is open', async () => {
await PageObjects.discover.selectTextBaseLang();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
const testQuery = 'from logstash-* | limit 100 | drop @timestamp';
await monacoEditor.setCodeEditorValue(testQuery);
await testSubjects.click('querySubmitButton');
Expand Down

0 comments on commit f8c4b9a

Please sign in to comment.