Merge #981

981: Warn if both remote and docker-in-docker are set. r=Emilgardis a=Alexhuszagh Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
cross-rs · Jul 28, 2022 · 557bac5 · 557bac5
2 parents 843ced9 + df7946f
commit 557bac5
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/docker/remote.rs b/src/docker/remote.rs
@@ -865,6 +865,10 @@ pub(crate) fn run(
 
     let mount_prefix = MOUNT_PREFIX;
 
+    if options.in_docker() {
+        msg_info.warn("remote and docker-in-docker are unlikely to work together when using cross. remote cross uses data volumes, so docker-in-docker should not be required.")?;
+    }
+
     // the logic is broken into the following steps
     // 1. get our unique identifiers and cleanup from a previous run.
     // 2. if not using persistent volumes, create a data volume