Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-470 #495

Merged
merged 1 commit into from
Nov 1, 2018
Merged

issue-470 #495

merged 1 commit into from
Nov 1, 2018

Conversation

sergey-galenko
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 45.946% when pulling 304c104 on sergey-galenko:master into 6c5b6e2 on cross-solution:master.

@cbleek
Copy link
Member

cbleek commented Oct 31, 2018

This looks very good. But we should merge it into our develop.

@TiSiE how do we do this?

cbleek referenced this pull request in yawik/Orders Oct 31, 2018
@sergey-galenko
Issue 470
c44ac80
@cbleek cbleek requested a review from TiSiE October 31, 2018 14:27
@TiSiE TiSiE changed the base branch from master to develop November 1, 2018 08:51
TiSiE
TiSiE approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@TiSiE TiSiE left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good.

Although the commit message could be approved the next time. At least, the issue should be mentioned with a preceding '#' to get github to link it automatically.

@TiSiE
Copy link
Member

TiSiE commented Nov 1, 2018

This relates to #470

@TiSiE TiSiE merged commit 304c104 into cross-solution:develop Nov 1, 2018
TiSiE added a commit that referenced this pull request Nov 1, 2018
@TiSiE
Merge pull request #495
e70242d 
* pr-495:
  issue-470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiSiE TiSiE TiSiE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sergey-galenko @coveralls @cbleek @TiSiE