Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Observe Func #10

Closed
fahedouch opened this issue Jan 12, 2022 · 4 comments
Closed

Implement Observe Func #10

fahedouch opened this issue Jan 12, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@fahedouch
Copy link
Collaborator

fahedouch commented Jan 12, 2022

What problem are you facing?

Like other Crossplane providers, Ansible provider should observe External Resource and save its observations in managed.ExternalObservation than send it to the Reconciler.

I think that we can check wether the managed ressource is ResourceUpToDate using ansible-playbook --diff --check

PS : our ansible-playbook sdk github.com/apenella/go-ansible/pkg/playbook natively support diff and check option https://pkg.go.dev/github.com/apenella/go-ansible/pkg/playbook#pkg-constants

How could Crossplane help solve your problem?

@fahedouch fahedouch added the enhancement New feature or request label Jan 12, 2022
@fahedouch fahedouch self-assigned this Jan 12, 2022
@morningspace
Copy link
Collaborator

@fahedouch FYI: I logged an issue in Ansible community while ago, and they had the same suggestion using diff, ansible/ansible#75248, but that has limitations.

@fahedouch
Copy link
Collaborator Author

Hey @morningspace ,

Yes I faced this limitation with shell tasks ( --check is not able to detect changes) . I think we should warn users of cases where the check is not effective by ansible-playbook

@fahedouch
Copy link
Collaborator Author

related ticket #18

@fahedouch
Copy link
Collaborator Author

fixed by #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants