-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init observe func #57
Init observe func #57
Conversation
c2ffc92
to
1baac1f
Compare
ee8d407
to
37c4af5
Compare
37c4af5
to
0f87def
Compare
f15a085
to
01930f2
Compare
d8f5603
to
1aed41a
Compare
@fahedouch Thanks for your continued effort on this PR! I believe we are very close to merge it. Could you please check the last few comments I appended above:
Lastly, a couple of CI pipeline jobs failed, could you please take look? Thanks again! |
503da0a
to
425b11a
Compare
425b11a
to
fe4e470
Compare
name: gcpbucket | ||
spec: | ||
forProvider: | ||
# PlaybookSet default to using a remote source - like playbookSet-remote.yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid the possible confusion to users, I think the comments here may need to be revised as the notion of PlaybookSet
is something we previously used and has been replaced by AnsibleRun
. Same applies to ansibleRun-inline.yaml
.
Another thing I just realized is that the current AnsibleRun
CR uses some spec fields that do not align with the design such as source
and module
, see the sample snippets at https://github.com/multicloudlab/crossplane-provider-ansible/blob/main/docs/design.md#inline where we actually do not have source
and module
, but use playbookInline
instead.
8d48087
to
8ac9087
Compare
Signed-off-by: Fahed DORGAA <fahed.dorgaa@gmail.com>
8ac9087
to
71e8537
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the final round of review, it looks perfect! BIG THANKS @fahedouch 👍
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fahedouch, morningspace The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Fahed DORGAA fahed.dorgaa@gmail.com
Description of your changes
Fixes # observe func WIP; ObserveAndDelete RunPolicy
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested