Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerDefinitions in ECS TaskDefintion should be objects and not a string #625

Closed
martinflemingdev opened this issue Mar 23, 2023 · 4 comments

Comments

@martinflemingdev
Copy link

What problem are you facing?

Currently the containerDefinitions array in the ECS TaskDefintion component takes a string representation of a JSON object.
This makes patching specific fields and verification very difficult.
Crossplane-contrib provider uses key:value objects instead.

ECS-task-def-container

How could Official AWS Provider help solve your problem?

Please consider adopting the same approach as crossplane-contrib provider and provide Key:Value pairs instead of a string representation of a JSON object.

@martinflemingdev martinflemingdev added the enhancement New feature or request label Mar 23, 2023
@martinflemingdev martinflemingdev changed the title containerDefinations in ECS TaskDefintion should be objects and not a string containerDefinitions in ECS TaskDefintion should be objects and not a string Mar 23, 2023
@jpoley
Copy link

jpoley commented Aug 10, 2023

This is blocking any use of patching, or real adoption. (can't use this string, and for that the community provider is better), also this is not specific to ecs, but an overall upjet related issue. we'd like a path forward

Copy link

github-actions bot commented Apr 7, 2024

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Aug 26, 2024
Copy link

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants