Change schemas to favor objects over JSON strings

[martinflemingdev]

This is a problem throughout all the Upbound providers, here's the same issue raised in the Upbound AWS provider.
crossplane-contrib/provider-upjet-aws#625

Patching a giant JSON string is not ideal for creating efficient Compositions.

2 Examples in the Data services for Upbound GCP Provider

CRD:

• apiVersion: bigquery.gcp.upbound.io/v1beta1
• kind: Table
• docs: https://marketplace.upbound.io/providers/upbound/provider-gcp/v0.35.0/resources/bigquery.gcp.upbound.io/Table/v1beta1

Problem:

• spec.forProvider.schema expects a stringified version of an array of objects instead of actual datatypes

Example:

apiVersion: bigquery.gcp.upbound.io/v1beta1
kind: Table
metadata:
  name: example
spec:
  forProvider:
    schema: |
      [ 
        {
          "name": "permalink",
          "type": "STRING",
          "mode": "NULLABLE",
          "description": "The Permalink"
        },
        {
          "name": "state",
          "type": "STRING",
          "mode": "NULLABLE",
          "description": "State where the head office is located"
        }
      ]

Possible Solution:

• Amend CRD to have schema type be an array of objects and not string

---

CRD:

• apiVersion: datacatalog.gcp.upbound.io/v1beta1
• kind: Entry
• docs: https://marketplace.upbound.io/providers/upbound/provider-gcp/v0.35.0/resources/datacatalog.gcp.upbound.io/Entry/v1beta1

Problem:

• spec.forProvider.schema expects a json string instead of actual datatypes

Example:

  schema: |
    {
      "columns": [
        {
          "column": "id",
          "type": "INT64",
          "description": "Unique identifier",
          "mode": "REQUIRED"
        },
        {
          "column": "name",
          "type": "STRING",
          "description": "Name of the individual",
          "mode": "NULLABLE"
        },
        {
          "column": "email",
          "type": "STRING",
          "description": "Email address",
          "mode": "NULLABLE"
        }
      ]
    }

Possible Solution:

• Amend CRD to have schema type be an object and not a string

[github-actions]

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

[github-actions]

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!