Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io::Result cleanup #232

Merged
merged 8 commits into from
Sep 18, 2019
Merged

io::Result cleanup #232

merged 8 commits into from
Sep 18, 2019

Conversation

zrzka
Copy link
Contributor

@zrzka zrzka commented Sep 18, 2019 •
edited
Loading

  • All functions in all crates (except crossterm_winapi) returns crossterm::Result (io::Result removed)
  • Only the crossterm_winapi crate functions returns io::Result
    • Result<T, ErrorKind> is defined in the crossterm_utils, which is not accessible from (-winapi)

Fixes #229

@zrzka
Replaced io::Result with utils::Result
ff517f0 
Unix platform only for now.

Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Blind Windows io::Result -> Result
f317331 
Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Fix import
7cce2da 
Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Remove unused import
ae114b0 
Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Fix unused import
c9407f2 
Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Fix the closure
093eb7a 
Signed-off-by: Robert Vojta <rvojta@me.com>
TimonPost
TimonPost reviewed Sep 18, 2019
View reviewed changes
examples/command.rs Outdated Show resolved Hide resolved
examples/command.rs Outdated Show resolved Hide resolved
examples/command.rs Outdated Show resolved Hide resolved
examples/command.rs Outdated Show resolved Hide resolved
examples/key_events.rs Outdated Show resolved Hide resolved
examples/key_events.rs Outdated Show resolved Hide resolved
@zrzka
Don’t drop fixes
24aaaba 
Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Remove pub from all examples and allow dead_code
64db777 
Signed-off-by: Robert Vojta <rvojta@me.com>
@TimonPost TimonPost merged commit 05d28b4 into crossterm-rs:master Sep 18, 2019
@zrzka zrzka deleted the zrzka/io-result-hunt branch September 19, 2019 11:56
december1981 pushed a commit to december1981/crossterm that referenced this pull request Oct 26, 2023
@patrickfreed
RUST-648 Reintroduce Document decoding w/ lossy UTF-8 conversion (cro…
d6e269e 
…ssterm-rs#232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimonPost TimonPost TimonPost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

io::Result vs crossterm::Result
2 participants
@zrzka @TimonPost