Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings management new #38

Merged
merged 13 commits into from
Nov 2, 2020
Merged

strings management new #38

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dc97620
added key naming select on UI
Oct 7, 2020
ba31060
Merge remote-tracking branch 'origin/master' into feat/strings-manage…
Oct 8, 2020
c70fcc8
added information about group
Oct 8, 2020
5d47304
implemented autocomplete of identifier based on selected pattern
Oct 9, 2020
c46818f
fixes
Oct 9, 2020
746d61b
used string identifier for the name of text element
Oct 12, 2020
e674de0
added UI for adding multiple strings simultaneously
Oct 12, 2020
9da50a9
WIP logic for adding multiple strings
Oct 14, 2020
b54e688
added logic for adding multiple strings
Oct 16, 2020
1406f04
fixed edit dialog
Oct 16, 2020
ea6d9ce
feat: added 'check' icon to used strings
Oct 21, 2020
02923f5
fixed issue with editing
Nov 1, 2020
cd8ec5a
reverted fix
Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes
  • Loading branch information
Yevheniy authored and Yevheniy committed Oct 9, 2020
commit c46818f06b32ade9b56191a4144b1c4d479ca50e
5 changes: 3 additions & 2 deletions ui/plugin.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@
let increment;
for (; ;) {
if ((strings || []).some(st => st.identifier === uniqueIdentifier)) {
increment = !!identifier ? (increment + 1) : 1;
increment = !!increment ? (increment + 1) : 1;
uniqueIdentifier = identifier + increment;
} else {
break;
Expand Down Expand Up @@ -546,7 +546,8 @@
strings.push({
id: e[0].data.id,
text: text,
fileId: Number(file)
fileId: Number(file),
identifier: identifier
});
if (selectedText.text) {
window.postMessage('useString', { id: e[0].data.id, text });
Expand Down