Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper handling when portal is being rejected #5

Open
JeDaYoshi opened this issue Oct 17, 2019 · 1 comment
Open

Proper handling when portal is being rejected #5

JeDaYoshi opened this issue Oct 17, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JeDaYoshi
Copy link
Member

Related to crybapp/portals#8. Portal should handle properly if it is being rejected from portals, instead of infinitely trying to connect. Probably @cryb/portals would work somewhat better if we did give some hints as of why it is being rejected instead of just returning nothing.
@darnfish darnfish added enhancement New feature or request good first issue Good for newcomers labels Oct 17, 2019
@darnfish
Copy link
Contributor

Was thinking of having better documentation when this type of crash occurs in development, I'll see what I can do 😄

JeDaYoshi pushed a commit that referenced this issue Feb 11, 2020
@Soliel
Merge pull request #5 from crybapp/master
0dc3f3c 
catchup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeDaYoshi @darnfish