The Unstaged Update #153
Draft
The Unstaged Update #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On this commit: - Migrated to latest Nuxt.js v2 and use @nuxt/bridge - Include Janus as a dependency instead of importing - Remove remains of JSMpeg/aperture - Switch to pnpm instead of yarn
Also includes a few fixes from the past commit, and a few bits I missed.
On this commit: - Multiple changes to make the player more reliable - Reduce latency by negotiating zero playout delay - Use a video element instead of canvas for PiP (why did I use canvas back then?) - Fix audio on Chromium-based browsers by asking for stereo - Fixes some control/mouse bugs - Grammar - Also remove some unused files with the @nuxt/bridge migration - And fix eslint This isn't the best code yet, but I am just pushing old fixes/changes from years ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request contains multiple changes that I did locally over the years, either as tests or quick fixes to get instances working for myself or friends.
They were not committed back then due to missing polish or merely lack of testing. But given the slightly broken nature of Cryb 1, and Cryb 2 still being a WIP given my limited time/bandwidth for the past years, I figured I'd take a focus on getting this done and improve the stability and quality of what we've currently got.
Included here:
@cryb/apertureis deprecated, and was a terrible idea since the beginning)@nuxt/bridgeyarntopnpm