Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: recent version of pystarport is not used #1000

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jul 6, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1000 (177190d) into master (4276950) will decrease coverage by 12.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1000       +/-   ##
===========================================
- Coverage   33.05%   20.68%   -12.37%     
===========================================
  Files         126      125        -1     
  Lines       20013    20011        -2     
===========================================
- Hits         6616     4140     -2476     
- Misses      12338    15253     +2915     
+ Partials     1059      618      -441     
Flag Coverage Δ
integration_tests 20.68% <ø> (+0.01%) ⬆️
integration_tests_byzantine 9.63% <ø> (ø)
integration_tests_gov 9.97% <ø> (ø)
integration_tests_grpc 9.95% <ø> (ø)
integration_tests_ibc ?
integration_tests_ledger 9.84% <ø> (ø)
integration_tests_slow 9.84% <ø> (ø)
integration_tests_solomachine 9.63% <ø> (ø)
integration_tests_upgrade ?
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

@mmsqe mmsqe force-pushed the update_pystarport branch 2 times, most recently from ca1fd03 to 7e65a48 Compare July 6, 2023 05:27
integration_tests/poetry.lock Outdated Show resolved Hide resolved
@mmsqe mmsqe marked this pull request as ready for review July 7, 2023 04:56
@mmsqe mmsqe requested a review from a team as a code owner July 7, 2023 04:56
@mmsqe mmsqe added this pull request to the merge queue Jul 7, 2023
Merged via the queue into crypto-org-chain:master with commit 9c295ce Jul 7, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants