Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: librocksdb version is not updated #1006

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Aug 10, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 10, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1006 (48573d2) into master (95acbf8) will decrease coverage by 3.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   33.05%   30.04%   -3.01%     
==========================================
  Files         126      125       -1     
  Lines       20014    20012       -2     
==========================================
- Hits         6616     6013     -603     
- Misses      12339    12955     +616     
+ Partials     1059     1044      -15     
Flag Coverage Δ
integration_tests 20.67% <ø> (-0.02%) ⬇️
integration_tests_byzantine 9.63% <ø> (ø)
integration_tests_gov 9.97% <ø> (ø)
integration_tests_grpc 9.95% <ø> (ø)
integration_tests_ibc 24.77% <ø> (ø)
integration_tests_ledger 9.84% <ø> (ø)
integration_tests_slow 9.85% <ø> (ø)
integration_tests_solomachine 9.63% <ø> (ø)
integration_tests_upgrade 9.95% <ø> (ø)
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review August 10, 2023 02:23
@mmsqe mmsqe requested a review from a team as a code owner August 10, 2023 02:23
nix/rocksdb.nix Outdated Show resolved Hide resolved
default.nix Outdated Show resolved Hide resolved
@yihuang yihuang added this pull request to the merge queue Aug 14, 2023
Merged via the queue into crypto-org-chain:master with commit 4650fba Aug 14, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants